Make possible to start TUI with installed WebUI

[adamkankovsky]

Trying to keep only inst.graphical in the future, instead of inst.webui, because webui as such should not be represented in KickStart.

[pep8speaks]

Hello @adamkankovsky! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-11-20 14:50:47 UTC

[poncovka]

Nice and clean. I like it! One note, I am pretty sure that starting Web UI in an installation environment without GUI will cause issues. In the previous version, we won't start Xorg if necessary. In your version, I guess the installer will switch to the text mode. Here is the problematic code:

anaconda/pyanaconda/display.py

Lines 305 to 311 in 93b3967

	if anaconda.gui_mode:
	mods = (tup[1] for tup in pkgutil.iter_modules(pyanaconda.ui.__path__, "pyanaconda.ui."))
	if "pyanaconda.ui.gui" not in mods:
	stdout_log.warning("Graphical user interface not available, falling back to text mode")
	anaconda.display_mode = constants.DisplayModes.TUI
	flags.usevnc = False
	flags.vncquestion = False

@jkonecny12 That's why every installation image needs to be properly tested if you want to have multiple images with different contents. It is easy to break the installer by removing a package from the installation environment.

[VladimirSlavik]

Thank you, mostly LGTM. What Vendy said - please keep the condition flow "one direction and one level".

[poncovka]

It looks great! Thank you!

[KKoukiou]

/kickstart-test --testtype smoke