Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to Wayland if Xorg is not available #5309

Conversation

M4rtinK
Copy link
Contributor

@M4rtinK M4rtinK commented Nov 9, 2023

In environments where Anaconda handles the overall GUI environment setup (eq. netinst/boot.iso) try to use Wayland compositor if Xorg server is not found.

Also add support for a (temporary?) boot inst.wayland boot option, that can be used to force Wayland compositor to be used. This makes it possible to check if Waland can be used in the given environment even if the given installation image still contains Xorg.

Very preliminary PR at the moment

TODO

  • find out why gnome-kiosk exits with RC == 1 without logging any errors
  • resolve all #FIXME lines

@M4rtinK M4rtinK added blocked Don't merge this pull request! f40 labels Nov 9, 2023
@github-actions github-actions bot added the webui label Nov 9, 2023
@M4rtinK M4rtinK force-pushed the master-use_wayland_if_xorg_is_not_found branch from 2f37b41 to 81308c8 Compare November 9, 2023 17:58
@M4rtinK
Copy link
Contributor Author

M4rtinK commented Nov 9, 2023

/build-image --boot.iso

@M4rtinK
Copy link
Contributor Author

M4rtinK commented Nov 9, 2023

/kickstart-test --testtype smoke

@M4rtinK
Copy link
Contributor Author

M4rtinK commented Nov 9, 2023

gnome_kiosk_rc_1
Not sure what's going on right now - haven't found any error messages in the logs from gnome-kiosk. It is invoked like this: gnome-kiosk --wayland-display :1 --sm-disable --wayland

Copy link

github-actions bot commented Nov 9, 2023

Images built based on commit 81308c8:

  • boot.iso: success

Download the images from the bottom of the job status page.

@M4rtinK M4rtinK force-pushed the master-use_wayland_if_xorg_is_not_found branch from 81308c8 to e1b08de Compare November 15, 2023 13:27
@M4rtinK
Copy link
Contributor Author

M4rtinK commented Nov 15, 2023

Lets try adding gnome-session as a dependency & build a boot iso with that. :)

@M4rtinK
Copy link
Contributor Author

M4rtinK commented Nov 15, 2023

/build-image --boot.iso

Copy link

Images built based on commit e1b08de:

  • boot.iso: success

Download the images from the bottom of the job status page.

@M4rtinK M4rtinK force-pushed the master-use_wayland_if_xorg_is_not_found branch from e1b08de to 8f16cb6 Compare November 16, 2023 16:36
@M4rtinK
Copy link
Contributor Author

M4rtinK commented Nov 16, 2023

Try adding python3-pam to the image.

@M4rtinK
Copy link
Contributor Author

M4rtinK commented Nov 16, 2023

/build-image --boot.iso

Copy link

Images built based on commit 8f16cb6:

  • boot.iso: success

Download the images from the bottom of the job status page.

@M4rtinK M4rtinK force-pushed the master-use_wayland_if_xorg_is_not_found branch from 8f16cb6 to 9a1bddb Compare November 16, 2023 18:24
@pep8speaks
Copy link

pep8speaks commented Nov 16, 2023

Hello @M4rtinK! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 28:1: E402 module level import not at top of file
Line 29:1: E402 module level import not at top of file
Line 30:1: E402 module level import not at top of file
Line 31:1: E402 module level import not at top of file

Line 54:1: E402 module level import not at top of file
Line 56:1: E402 module level import not at top of file
Line 285:1: E265 block comment should start with '# '
Line 285:100: E501 line too long (148 > 99 characters)
Line 302:5: E265 block comment should start with '# '
Line 315:1: E302 expected 2 blank lines, found 1

Line 37:1: E302 expected 2 blank lines, found 1
Line 119:5: E303 too many blank lines (2)

Line 21:1: E265 block comment should start with '# '
Line 24:1: E265 block comment should start with '# '
Line 25:1: E402 module level import not at top of file
Line 35:1: E402 module level import not at top of file

Line 18:1: E302 expected 2 blank lines, found 1
Line 26:1: E302 expected 2 blank lines, found 1
Line 32:1: E302 expected 2 blank lines, found 1
Line 32:100: E501 line too long (101 > 99 characters)
Line 103:27: E703 statement ends with a semicolon
Line 114:44: E703 statement ends with a semicolon
Line 141:1: E302 expected 2 blank lines, found 1
Line 142:100: E501 line too long (139 > 99 characters)
Line 147:100: E501 line too long (134 > 99 characters)
Line 153:27: E201 whitespace after '['
Line 153:40: E202 whitespace before ']'
Line 186:100: E501 line too long (132 > 99 characters)
Line 195:1: E305 expected 2 blank lines after class or function definition, found 1
Line 197:1: W391 blank line at end of file

Comment last updated at 2024-01-03 14:25:07 UTC

@M4rtinK M4rtinK force-pushed the master-use_wayland_if_xorg_is_not_found branch from 9a1bddb to b4d6c43 Compare November 16, 2023 19:28
@M4rtinK
Copy link
Contributor Author

M4rtinK commented Nov 16, 2023

/build-image --boot.iso

Copy link

Images built based on commit b4d6c43:

  • boot.iso: success

Download the images from the bottom of the job status page.

@M4rtinK M4rtinK force-pushed the master-use_wayland_if_xorg_is_not_found branch from b4d6c43 to 29c51ce Compare November 20, 2023 12:33
@M4rtinK
Copy link
Contributor Author

M4rtinK commented Nov 20, 2023

Looks like XWayland (xorg-x11-server-Xwayland) is not installed on the boot.iso - lets pull that in. :)

@M4rtinK
Copy link
Contributor Author

M4rtinK commented Nov 20, 2023

/build-image --boot.iso

Copy link

Images built based on commit 29c51ce:

  • boot.iso: success

Download the images from the bottom of the job status page.

jexposit added a commit to jexposit/anaconda that referenced this pull request Mar 4, 2024
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native
Wayland client.

This commit is a follow up on the work done by Neal Gompa [1], Martin
Kolman and Ray Strode [2]. Credit goes to them for the code I copied
and pasted.

[1] rhinstaller#5401
[2] rhinstaller#5309

Co-authored-by: Neal Gompa <neal@gompa.dev>
Co-authored-by: Martin Kolman <mkolman@redhat.com>
Co-authored-by: Ray Strode <rstrode@redhat.com>
jexposit added a commit to jexposit/anaconda that referenced this pull request Mar 4, 2024
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native
Wayland client.

This commit is a follow up on the work done by Neal Gompa [1], Martin
Kolman and Ray Strode [2]. Credit goes to them for the code I copied
and pasted.

[1] rhinstaller#5401
[2] rhinstaller#5309

Co-authored-by: Neal Gompa <neal@gompa.dev>
Co-authored-by: Martin Kolman <mkolman@redhat.com>
Co-authored-by: Ray Strode <rstrode@redhat.com>
jexposit added a commit to jexposit/anaconda that referenced this pull request Mar 5, 2024
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native
Wayland client.

This commit is a follow up on the work done by Neal Gompa [1], Martin
Kolman and Ray Strode [2]. Credit goes to them for the code I copied
and pasted.

[1] rhinstaller#5401
[2] rhinstaller#5309

Co-authored-by: Neal Gompa <neal@gompa.dev>
Co-authored-by: Martin Kolman <mkolman@redhat.com>
Co-authored-by: Ray Strode <rstrode@redhat.com>
M4rtinK added a commit to M4rtinK/anaconda that referenced this pull request Mar 13, 2024
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native
Wayland client.

This commit is a follow up on the work done by Neal Gompa [1] and
Martin Kolman [2]. Credit goes to them for the code I copied and pasted.

[1] rhinstaller#5401
[2] rhinstaller#5309

Co-authored-by: Neal Gompa <neal@gompa.dev>
Co-authored-by: Martin Kolman <mkolman@redhat.com>
Co-authored-by: Ray Strode <rstrode@redhat.com>
M4rtinK added a commit to jexposit/anaconda that referenced this pull request Apr 10, 2024
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native
Wayland client.

This commit is a follow up on the work done by Neal Gompa [1], Martin
Kolman and Ray Strode [2]. Credit goes to them for the code I copied
and pasted.

[1] rhinstaller#5401
[2] rhinstaller#5309

Co-authored-by: Neal Gompa <neal@gompa.dev>
Co-authored-by: Martin Kolman <mkolman@redhat.com>
Co-authored-by: Ray Strode <rstrode@redhat.com>
M4rtinK added a commit to M4rtinK/anaconda that referenced this pull request Apr 11, 2024
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native
Wayland client.

This commit is a follow up on the work done by Neal Gompa [1], Martin
Kolman and Ray Strode [2]. Credit goes to them for the code I copied
and pasted.

[1] rhinstaller#5401
[2] rhinstaller#5309

Co-authored-by: Neal Gompa <neal@gompa.dev>
Co-authored-by: Martin Kolman <mkolman@redhat.com>
Co-authored-by: Ray Strode <rstrode@redhat.com>
M4rtinK added a commit to M4rtinK/anaconda that referenced this pull request Apr 15, 2024
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native
Wayland client.

This commit is a follow up on the work done by Neal Gompa [1], Martin
Kolman and Ray Strode [2]. Credit goes to them for the code I copied
and pasted.

[1] rhinstaller#5401
[2] rhinstaller#5309

Co-authored-by: Neal Gompa <neal@gompa.dev>
Co-authored-by: Martin Kolman <mkolman@redhat.com>
Co-authored-by: Ray Strode <rstrode@redhat.com>
M4rtinK added a commit to jexposit/anaconda that referenced this pull request Apr 15, 2024
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native
Wayland client.

This commit is a follow up on the work done by Neal Gompa [1], Martin
Kolman and Ray Strode [2]. Credit goes to them for the code I copied
and pasted.

[1] rhinstaller#5401
[2] rhinstaller#5309

Co-authored-by: Neal Gompa <neal@gompa.dev>
Co-authored-by: Martin Kolman <mkolman@redhat.com>
Co-authored-by: Ray Strode <rstrode@redhat.com>
M4rtinK added a commit to M4rtinK/anaconda that referenced this pull request Apr 18, 2024
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native
Wayland client.

This commit is a follow up on the work done by Neal Gompa [1], Martin
Kolman and Ray Strode [2]. Credit goes to them for the code I copied
and pasted.

[1] rhinstaller#5401
[2] rhinstaller#5309

Co-authored-by: Neal Gompa <neal@gompa.dev>
Co-authored-by: Martin Kolman <mkolman@redhat.com>
Co-authored-by: Ray Strode <rstrode@redhat.com>
M4rtinK added a commit to jexposit/anaconda that referenced this pull request Apr 26, 2024
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native
Wayland client.

This commit is a follow up on the work done by Neal Gompa [1], Martin
Kolman and Ray Strode [2]. Credit goes to them for the code I copied
and pasted.

[1] rhinstaller#5401
[2] rhinstaller#5309

Co-authored-by: Neal Gompa <neal@gompa.dev>
Co-authored-by: Martin Kolman <mkolman@redhat.com>
Co-authored-by: Ray Strode <rstrode@redhat.com>
M4rtinK added a commit to M4rtinK/anaconda that referenced this pull request Apr 26, 2024
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native
Wayland client.

This commit is a follow up on the work done by Neal Gompa [1], Martin
Kolman and Ray Strode [2]. Credit goes to them for the code I copied
and pasted.

[1] rhinstaller#5401
[2] rhinstaller#5309

Co-authored-by: Neal Gompa <neal@gompa.dev>
Co-authored-by: Martin Kolman <mkolman@redhat.com>
Co-authored-by: Ray Strode <rstrode@redhat.com>
Copy link

This PR is stale because it has been open 60 days with no activity.
Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Apr 30, 2024
M4rtinK added a commit to M4rtinK/anaconda that referenced this pull request Apr 30, 2024
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native
Wayland client.

This commit is a follow up on the work done by Neal Gompa [1], Martin
Kolman and Ray Strode [2]. Credit goes to them for the code I copied
and pasted.

[1] rhinstaller#5401
[2] rhinstaller#5309

Co-authored-by: Neal Gompa <neal@gompa.dev>
Co-authored-by: Martin Kolman <mkolman@redhat.com>
Co-authored-by: Ray Strode <rstrode@redhat.com>
M4rtinK added a commit to M4rtinK/anaconda that referenced this pull request Apr 30, 2024
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native
Wayland client.

This commit is a follow up on the work done by Neal Gompa [1], Martin
Kolman and Ray Strode [2]. Credit goes to them for the code I copied
and pasted.

[1] rhinstaller#5401
[2] rhinstaller#5309

Co-authored-by: Neal Gompa <neal@gompa.dev>
Co-authored-by: Martin Kolman <mkolman@redhat.com>
Co-authored-by: Ray Strode <rstrode@redhat.com>
M4rtinK added a commit to M4rtinK/anaconda that referenced this pull request May 15, 2024
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native
Wayland client.

This commit is a follow up on the work done by Neal Gompa [1], Martin
Kolman and Ray Strode [2]. Credit goes to them for the code I copied
and pasted.

[1] rhinstaller#5401
[2] rhinstaller#5309

Co-authored-by: Neal Gompa <neal@gompa.dev>
Co-authored-by: Martin Kolman <mkolman@redhat.com>
Co-authored-by: Ray Strode <rstrode@redhat.com>
jexposit added a commit to jexposit/anaconda that referenced this pull request May 23, 2024
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native
Wayland client.

This commit is a follow up on the work done by Neal Gompa [1], Martin
Kolman and Ray Strode [2]. Credit goes to them for the code I copied
and pasted.

[1] rhinstaller#5401
[2] rhinstaller#5309

Resolves: https://issues.redhat.com/browse/RHEL-38399
Co-authored-by: Neal Gompa <neal@gompa.dev>
Co-authored-by: Martin Kolman <mkolman@redhat.com>
Co-authored-by: Ray Strode <rstrode@redhat.com>
M4rtinK pushed a commit to jexposit/anaconda that referenced this pull request May 27, 2024
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native
Wayland client.

This commit is a follow up on the work done by Neal Gompa [1], Martin
Kolman and Ray Strode [2]. Credit goes to them for the code I copied
and pasted.

[1] rhinstaller#5401
[2] rhinstaller#5309

Co-authored-by: Neal Gompa <neal@gompa.dev>
Co-authored-by: Martin Kolman <mkolman@redhat.com>
Co-authored-by: Ray Strode <rstrode@redhat.com>

Resolves: RHEL-38399
M4rtinK pushed a commit to jexposit/anaconda that referenced this pull request May 27, 2024
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native
Wayland client.

This commit is a follow up on the work done by Neal Gompa [1], Martin
Kolman and Ray Strode [2]. Credit goes to them for the code I copied
and pasted.

[1] rhinstaller#5401
[2] rhinstaller#5309

Co-authored-by: Neal Gompa <neal@gompa.dev>
Co-authored-by: Martin Kolman <mkolman@redhat.com>
Co-authored-by: Ray Strode <rstrode@redhat.com>

Resolves: RHEL-38399
M4rtinK pushed a commit to jexposit/anaconda that referenced this pull request May 27, 2024
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native
Wayland client.

This commit is a follow up on the work done by Neal Gompa [1], Martin
Kolman and Ray Strode [2]. Credit goes to them for the code I copied
and pasted.

[1] rhinstaller#5401
[2] rhinstaller#5309

Co-authored-by: Neal Gompa <neal@gompa.dev>
Co-authored-by: Martin Kolman <mkolman@redhat.com>
Co-authored-by: Ray Strode <rstrode@redhat.com>

Resolves: RHEL-38399
M4rtinK pushed a commit to jexposit/anaconda that referenced this pull request May 28, 2024
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native
Wayland client.

This commit is a follow up on the work done by Neal Gompa [1], Martin
Kolman and Ray Strode [2]. Credit goes to them for the code I copied
and pasted.

[1] rhinstaller#5401
[2] rhinstaller#5309

Co-authored-by: Neal Gompa <neal@gompa.dev>
Co-authored-by: Martin Kolman <mkolman@redhat.com>
Co-authored-by: Ray Strode <rstrode@redhat.com>

Resolves: RHEL-38399
Copy link

This PR was closed because it has been stalled for 30 days with no activity.

@github-actions github-actions bot closed this May 30, 2024
M4rtinK pushed a commit to jexposit/anaconda that referenced this pull request Jun 6, 2024
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native
Wayland client.

This commit is a follow up on the work done by Neal Gompa [1], Martin
Kolman and Ray Strode [2]. Credit goes to them for the code I copied
and pasted.

[1] rhinstaller#5401
[2] rhinstaller#5309

Co-authored-by: Neal Gompa <neal@gompa.dev>
Co-authored-by: Martin Kolman <mkolman@redhat.com>
Co-authored-by: Ray Strode <rstrode@redhat.com>

Resolves: RHEL-38399
jkonecny12 pushed a commit to jkonecny12/anaconda that referenced this pull request Aug 14, 2024
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native
Wayland client.

This commit is a follow up on the work done by Neal Gompa [1], Martin
Kolman and Ray Strode [2]. Credit goes to them for the code I copied
and pasted.

[1] rhinstaller#5401
[2] rhinstaller#5309

Co-authored-by: Neal Gompa <neal@gompa.dev>
Co-authored-by: Martin Kolman <mkolman@redhat.com>
Co-authored-by: Ray Strode <rstrode@redhat.com>

Resolves: RHEL-38399
(cherry picked from commit 8800331)
jkonecny12 pushed a commit to jkonecny12/anaconda that referenced this pull request Aug 14, 2024
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native
Wayland client.

This commit is a follow up on the work done by Neal Gompa [1], Martin
Kolman and Ray Strode [2]. Credit goes to them for the code I copied
and pasted.

[1] rhinstaller#5401
[2] rhinstaller#5309

Co-authored-by: Neal Gompa <neal@gompa.dev>
Co-authored-by: Martin Kolman <mkolman@redhat.com>
Co-authored-by: Ray Strode <rstrode@redhat.com>

Resolves: RHEL-38399
Resolves: https://fedoraproject.org/wiki/Changes/AnacondaWebUIforFedoraWorkstation
(cherry picked from commit 8800331)
jkonecny12 pushed a commit to jkonecny12/anaconda that referenced this pull request Aug 21, 2024
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native
Wayland client.

This commit is a follow up on the work done by Neal Gompa [1], Martin
Kolman and Ray Strode [2]. Credit goes to them for the code I copied
and pasted.

[1] rhinstaller#5401
[2] rhinstaller#5309

Co-authored-by: Neal Gompa <neal@gompa.dev>
Co-authored-by: Martin Kolman <mkolman@redhat.com>
Co-authored-by: Ray Strode <rstrode@redhat.com>

Resolves: RHEL-38399
Resolves: https://fedoraproject.org/wiki/Changes/AnacondaWebUIforFedoraWorkstation
(cherry picked from commit 8800331)
jkonecny12 pushed a commit to jkonecny12/anaconda that referenced this pull request Aug 28, 2024
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native
Wayland client.

This commit is a follow up on the work done by Neal Gompa [1], Martin
Kolman and Ray Strode [2]. Credit goes to them for the code I copied
and pasted.

[1] rhinstaller#5401
[2] rhinstaller#5309

Co-authored-by: Neal Gompa <neal@gompa.dev>
Co-authored-by: Martin Kolman <mkolman@redhat.com>
Co-authored-by: Ray Strode <rstrode@redhat.com>

Resolves: RHEL-38399
Resolves: https://fedoraproject.org/wiki/Changes/AnacondaWebUIforFedoraWorkstation
(cherry picked from commit 8800331)
jkonecny12 pushed a commit to jkonecny12/anaconda that referenced this pull request Sep 3, 2024
Start GNOME Kiosk as a Wayland compositor and run Anaconda as a native
Wayland client.

This commit is a follow up on the work done by Neal Gompa [1], Martin
Kolman and Ray Strode [2]. Credit goes to them for the code I copied
and pasted.

[1] rhinstaller#5401
[2] rhinstaller#5309

Co-authored-by: Neal Gompa <neal@gompa.dev>
Co-authored-by: Martin Kolman <mkolman@redhat.com>
Co-authored-by: Ray Strode <rstrode@redhat.com>

Resolves: RHEL-38399
Resolves: https://fedoraproject.org/wiki/Changes/AnacondaWebUIforFedoraWorkstation
(cherry picked from commit 8800331)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Don't merge this pull request! f41 stale webui
Development

Successfully merging this pull request may close these issues.

4 participants