Webui tests more robust going back and variant agnostic #5331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When going back let's use (in cases where we don't want to test the Back buttons specifically) sidebar navigation which is independent of hidden steps when going back.
Make Installer class aware of hidden steps and update the methods for moving between steps accordingly.
|
Hello @rvykydal! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
|
Migrated to the new repository: rhinstaller/anaconda-webui#51 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first two commits are from this PR: #5310
With this PR, adding
(which effectively hides welcome and accounts step in the installer) before
open()of all the tests where it makes sense the tests are still passing (except for pixel tests). So they should break less easily when adding some other step in the future (as it happened when I was adding users spoke).As a follow-up the installer.py helper could be a bit cleaned and re-factored and maybe some tests run in multiple variants.