Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic bootupd support #5342

Merged

Conversation

VladimirSlavik
Copy link
Contributor

@VladimirSlavik VladimirSlavik commented Nov 23, 2023

It seems to work, mostly. Needs explicit partitioning in kickstart.

Replaces #5298 which has initial discussion.

TODOs:

  • tests
  • release note
  • commit messages

@pep8speaks
Copy link

pep8speaks commented Nov 23, 2023

Hello @VladimirSlavik! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 24:1: E302 expected 2 blank lines, found 1

Comment last updated at 2023-11-29 15:04:09 UTC

@VladimirSlavik VladimirSlavik marked this pull request as draft November 23, 2023 14:24
@VladimirSlavik VladimirSlavik added release note required Write a release note for this change. and removed documentation labels Nov 23, 2023
@poncovka
Copy link
Contributor

@VladimirSlavik This seems to fix the issue with kickstart partitioning on multiple disks: storaged-project/blivet#1174

@VladimirSlavik
Copy link
Contributor Author

/kickstart-test --testtype smoke

Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work. Thanks a lot for this!

pyanaconda/modules/storage/bootloader/installation.py Outdated Show resolved Hide resolved
@VladimirSlavik
Copy link
Contributor Author

/kickstart-test --testtype smoke

@poncovka
Copy link
Contributor

This pull request will be rebased on top of #5350 to enable collection and configuration of the kernel arguments during the installation with the bootupd bootloader. See #5298 (comment) for more information.

Copy link
Contributor

@poncovka poncovka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, it looks good to me. Thank you!

docs/release-notes/bootupd.rst Outdated Show resolved Hide resolved
Original commit message from Colin Walters was:

The https://github.com/coreos/bootupd project was created to fill
the gap in bootloader management for ostree-based systems.

When it was created, it was just integrated into Fedora CoreOS
and derivatives; this left the Atomic Desktops (Silverblue etc.)
as unfixed, and it was never used by RHEL for Edge.

This PR is aiming to circle back and close that gap.  We
detect if bootupd is in the target root; if it is, then
we skip the regular bootloader work, and just run bootupd to
perform the installation.

The other hacks we have around the grub config are no longer
necessary in this mode.
@VladimirSlavik
Copy link
Contributor Author

/kickstart-test --testtype smoke

@VladimirSlavik
Copy link
Contributor Author

/kickstart-test --testtype bootloader

@VladimirSlavik
Copy link
Contributor Author

I think this might be it...

@VladimirSlavik
Copy link
Contributor Author

/kickstart-test rpm-ostree-container

Copy link
Contributor

@poncovka poncovka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@VladimirSlavik VladimirSlavik merged commit 3e5d011 into rhinstaller:master Nov 30, 2023
17 of 18 checks passed
@VladimirSlavik VladimirSlavik deleted the master-bootupd-automatic branch November 30, 2023 09:43
@cgwalters
Copy link
Contributor

Awesome, thanks! Looking forward to trying this out once there's a built ISO in rawhide/ELN.

@travier
Copy link
Contributor

travier commented Nov 30, 2023

🎉 Thanks for the work!

Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great solution, thanks for working on this!

@teg
Copy link

teg commented Dec 1, 2023

Nice work @poncovka and @VladimirSlavik !

@cgwalters
Copy link
Contributor

Followup in #5363

@cgwalters
Copy link
Contributor

Another followup item I just noticed CentOS/centos-bootc#97 which may or may not need Anaconda work, will consider

poncovka added a commit to poncovka/centos-bootc that referenced this pull request Dec 7, 2023
The kickstart file works with a Fedora 40+ (or ELN) installer ISO as
it requires rhinstaller/anaconda#5342.

Co-authored-by: Colin Walters <walters@verbum.org>
poncovka added a commit to poncovka/centos-bootc that referenced this pull request Dec 15, 2023
The kickstart file works with a Fedora 40+ (or ELN) installer ISO as
it requires rhinstaller/anaconda#5342.

Co-authored-by: Colin Walters <walters@verbum.org>
@rvykydal rvykydal mentioned this pull request Jan 17, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f40 release note required Write a release note for this change.
Development

Successfully merging this pull request may close these issues.

7 participants