Boot not required #5371
Closed
Boot not required #5371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In general is recommended to have a separate /boot, but not strictly required. In some cases it is required but we need to add API for that, because it depends mainly on the filesystem of the root partition. So now the requirement regards mainly biosboot and efi partitions, which is dependent on the platform. TODO: update tests
Instead of adding GetRecommendedMountPoints to GetRequiredMountpoints replace the both with a bit more generic GetMountPointConstraints that would add recommended/required flag to the constraints.
rvykydal
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
Hello @rvykydal! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the webui PR: TODO
In the PR I was first adding
GetRecommendedMountPointsto the existingGetRequiredMountPointsbut in the end would like to use the newly addedGetMountPointConstraintsthat would replace both of them (after merging the webui part which is replacing the API calls).TODO: