Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use blivet COPR for container builds #5393

Merged

Conversation

jkonecny12
Copy link
Member

Blivet project is building COPR daily builds always from master branch. However, Fedora-39 Anaconda is not compatible with master blivet because of removal of NVDIMM support.

This will fix container builds for Fedora-39.

@jkonecny12 jkonecny12 added infrastructure Changes affecting mostly infrastructure f39 labels Jan 3, 2024
Blivet project is building COPR daily builds always from `master`
branch. However, Fedora-39 Anaconda is not compatible with `master`
blivet because of removal of NVDIMM support.

This will fix container builds for Fedora-39.
@jkonecny12 jkonecny12 force-pushed the fedora-39-fix-container-builds branch from 34a43cb to b6b4aab Compare January 3, 2024 13:26
Copy link
Contributor

@KKoukiou KKoukiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally you need to submit this PR on master and conditionalize this, so that when we branch again it wont slip in.

@jkonecny12
Copy link
Member Author

This is harder to achieve. We would need to find out when Fedora is GA not branched. After the branching there is a lot of development happening on both sides where we want the newest greatest blivet, however, after GA we don't.

Do you know how to reasonably detect that Fedora is in GA state now?

@jkonecny12
Copy link
Member Author

/kickstart-test --waive infra only

@jkonecny12 jkonecny12 merged commit 86b2c6d into rhinstaller:fedora-39 Jan 3, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f39 infrastructure Changes affecting mostly infrastructure
Development

Successfully merging this pull request may close these issues.

2 participants