Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port kernel features support to fedora #5414

Merged

Conversation

rvykydal
Copy link
Contributor

This is another take on #4858.
The original PR was updated by calling the match_available_packages in UI from the dnf manager / payload module (#4858 (comment)).

@pep8speaks
Copy link

pep8speaks commented Jan 19, 2024

Hello @rvykydal! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-01-22 09:44:15 UTC

@github-actions github-actions bot added the f40 label Jan 19, 2024
@rvykydal rvykydal marked this pull request as draft January 19, 2024 09:12
@rvykydal rvykydal force-pushed the port-kernel-features-support-to-fedora branch from 1c32658 to 3d9a7c7 Compare January 19, 2024 09:17
@rvykydal
Copy link
Contributor Author

/kickstar-test --testtype smoke

@rvykydal
Copy link
Contributor Author

/kickstart-test --testtype smoke

@rvykydal rvykydal marked this pull request as ready for review January 19, 2024 09:45
@Conan-Kudo
Copy link
Contributor

Can we also get a setting for forcing a particular variant in the profile configuration for particular architectures?

@jkonecny12
Copy link
Member

I think you can extend it with another PR. However, we have to focus only on the high priority required parts.

Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the nitpick, looks great to me. Thanks!

# Only showing parts of kernel box relevant for current system.
self._available_kernels = get_available_kernel_features(self.payload.proxy)

if not conf.ui.show_kernel_options:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change this to

show_kernels = False
if conf.ui.show_kernels_options:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@rvykydal rvykydal force-pushed the port-kernel-features-support-to-fedora branch from 3d9a7c7 to 3bae673 Compare January 22, 2024 09:43
Add GUI options for selecting kernel-64k if available.

Resolves: rhbz#2164819

Updated by rvykydal@redhat.com to call the match_available_packages
from the dnf manager in payload module.
Add a new screen to Software selection spoke that appears after addon
selection.
This screen allows for selecting non-standard kernels.

Resolves: rhbz#2164819
@rvykydal rvykydal force-pushed the port-kernel-features-support-to-fedora branch from 3bae673 to 731d652 Compare January 22, 2024 09:44
@rvykydal
Copy link
Contributor Author

/kickstart-test --testtype smoke

Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well.

@rvykydal rvykydal merged commit c0d803e into rhinstaller:master Jan 30, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

6 participants