-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port kernel features support to fedora #5414
Port kernel features support to fedora #5414
Conversation
1c32658
to
3d9a7c7
Compare
/kickstar-test --testtype smoke |
/kickstart-test --testtype smoke |
Can we also get a setting for forcing a particular variant in the profile configuration for particular architectures? |
I think you can extend it with another PR. However, we have to focus only on the high priority required parts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the nitpick, looks great to me. Thanks!
# Only showing parts of kernel box relevant for current system. | ||
self._available_kernels = get_available_kernel_features(self.payload.proxy) | ||
|
||
if not conf.ui.show_kernel_options: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change this to
show_kernels = False
if conf.ui.show_kernels_options:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
3d9a7c7
to
3bae673
Compare
Add GUI options for selecting kernel-64k if available. Resolves: rhbz#2164819 Updated by rvykydal@redhat.com to call the match_available_packages from the dnf manager in payload module.
Add a new screen to Software selection spoke that appears after addon selection. This screen allows for selecting non-standard kernels. Resolves: rhbz#2164819
3bae673
to
731d652
Compare
/kickstart-test --testtype smoke |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as well.
This is another take on #4858.
The original PR was updated by calling the match_available_packages in UI from the dnf manager / payload module (#4858 (comment)).