Remove libgnomekbd

[jexposit]

libgnomekbd is a C library used by Anaconda to display the keyboard preview widget. It is stuck in GTK 3 and X11 (libxklavier).

Replace it with Tecla.

[pep8speaks]

Hello @jexposit! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-01-22 16:36:25 UTC

[jexposit]

/build-image --boot.iso

[github-actions]

Images built based on commit dfaf84d:

• boot.iso: success

Download the images from the bottom of the job status page.

[M4rtinK]

Looks good to me, thanks a lot! :)

I also really like how the tecla process is cleaned up when you click outside outside the window & IMHO perfectly appropriate here where one does not enter any data, unlike with the connection editor with its --keep-above, where it makes sense to not loose the window. :)

[jkonecny12]

Looks good to me. Thanks!

[rvykydal]

Looks good to me, but when I tried the iso generated in the comment above, maximizing the tecla window with icon and then clicking minimize icon gets me stuck in it.

[jkonecny12]

BTW, working on resolving the failed test. I'm getting you into the Cockpit CI allowed users.

[jexposit]

Nice catch @rvykydal. It looks like a GNOME Kiosk bug. I reported it upstream:
https://gitlab.gnome.org/GNOME/gnome-kiosk/-/issues/20

Meanwhile, I'll investigate if it is possible to workaround this issue by disabling the maximize and minimize buttons, as they are not useful for us.

nm-connection-editor also displays them, but clicking them has no effect.

[jexposit]

Adding a file in /etc/gtk-4.0/settings.ini with content:

[Settings]
gtk-decoration-layout=:close

Removes the minimize and maximize buttons.

However, it looks like this used to work:
https://github.com/rhinstaller/anaconda/blob/master/data/window-manager/config/org.gnome.desktop.wm.preferences.gschema.override#L2

But at some point it got broken. It looks like a different bug to fix in our side.

[rvykydal]

To be clear, personally I wouldn't block the PR on the min/max buttons issue, thank you for investigating it. We could handle it as a separate issue, but I'll leave the decision on you.

[jexposit]

Here is the fix for the minimize and maximize buttons:
#5421

Marked as draft as I had a few questions.