Rhel9 more ostreecontainer #5423
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @cgwalters! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-01-25 01:29:26 UTC |
Original commit message from Colin Walters was: The https://github.com/coreos/bootupd project was created to fill the gap in bootloader management for ostree-based systems. When it was created, it was just integrated into Fedora CoreOS and derivatives; this left the Atomic Desktops (Silverblue etc.) as unfixed, and it was never used by RHEL for Edge. This PR is aiming to circle back and close that gap. We detect if bootupd is in the target root; if it is, then we skip the regular bootloader work, and just run bootupd to perform the installation. The other hacks we have around the grub config are no longer necessary in this mode. (cherry picked from commit 8e690d5) Related: RHEL-2250
(cherry picked from commit 0d42d2f) Related: RHEL-2250
This is an even newer behavior that takes over handling of the "UUID stamp files", which we want in general instead of using the static labels. Note `--write-uuid` implies `--with-static-configs`. This should fix this use case: ``` clearpart --all --initlabel --disklabel=gpt reqpart --add-boot part / --grow --fstype xfs ``` Whereas right now we require: ``` clearpart --all --initlabel --disklabel=gpt reqpart part /boot --size=1000 --fstype=ext4 --label=boot part / --grow --fstype xfs ``` Specifically the `--label=boot`. (cherry picked from commit 7b091de) Related: RHEL-2250
cgwalters
force-pushed
the
rhel9-more-ostreecontainer
branch
from
2d30325
to
6e18b20
Compare
|
/build-image --boot-iso |
|
Hi! I will see if we can somehow incorporate this PR, but I have ready the full stack of commits (there are actually more changes required for the bootupd support) that I am currently testing. |
|
Ah ok! Feel free to close this then. |
Closing, the issue is handled by #5424. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #5399
Not tested locally; the conflicts were mostly straightforward except there was a large one on the bootloader unit tests that I didn't stare at too hard and just accepted the incoming.