sdboot: forward port content from PR#5297 #5458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Live images are already installed with grub2 and cannot be changed on the fly to systemd-boot (well at least without a lot of extra work). In case the user passed one of the systemd-boot options to anaconda, we should be a bit more graceful than failing to run the updateloader entries script as currently happens. This change, when run on non webUI installs results in a popup notifying the user there is an error in the bootloader configuration and asking if they would like to ignore it. Resolves: rhbz#2234638 Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
KKoukiou
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
The installer is not able to verify requirements of the selected bootloader with other types of payload, like live images and rpmostree installations. Let's allow systemd-boot only for package installations for now and deal with other use cases later. Related: rhbz#2234638
jkonecny12
force-pushed
the
sdboot-cherry-pickpr-5297
branch
from
a10b1fa
to
a064c6a
Compare
jkonecny12
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
I fixed the pep8 issue reported here. Hopefully you don't mind. |
jkonecny12
approved these changes
Feb 7, 2024
|
/kickstart-test --testtype smoke |
Hmm however, i see the form is still active and the user can seemingly continue? Or it's not the case. |
|
It works like this:
The behavior is not great but given to the fact that users have to explicitly change kernel boot arguments or launch Anaconda with a specific We can disable the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.