-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
startup: Set up the session bus on the boot.iso #5464
Conversation
The user instance of systemd that we start from Anaconda on the boot.iso runs a session bus at `XDG_RUNTIME_DIR/bus`. Other services started by Anaconda might call `bus-launch --autolaunch` to find the existing session bus (or start a new one), but `dbus-launch` ignores the `XDG_RUNTIME_DIR` environment variable. * Let's set the `DBUS_SESSION_BUS_ADDRESS` environment variable to fix that. * Create the `SessionBus` object for an easy access to the session bus. * Always start the user instance of systemd on a boot.iso for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I tested it intensively in #5463
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/packit build |
/kickstart-test --testtype smoke |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as well, thanks a lot! :)
/packit build |
The user instance of systemd that we start from Anaconda on the boot.iso runs a session bus at
XDG_RUNTIME_DIR/bus
. Other services started by Anaconda might callbus-launch --autolaunch
to find the existing session bus (or start a new one), butdbus-launch
ignores theXDG_RUNTIME_DIR
environment variable.DBUS_SESSION_BUS_ADDRESS
environment variable to fix that.SessionBus
object for an easy access to the session bus.