Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

startup: Set up the session bus on the boot.iso #5464

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

poncovka
Copy link
Contributor

@poncovka poncovka commented Feb 8, 2024

The user instance of systemd that we start from Anaconda on the boot.iso runs a session bus at XDG_RUNTIME_DIR/bus. Other services started by Anaconda might call bus-launch --autolaunch to find the existing session bus (or start a new one), but dbus-launch ignores the XDG_RUNTIME_DIR environment variable.

  • Let's set the DBUS_SESSION_BUS_ADDRESS environment variable to fix that.
  • Create the SessionBus object for an easy access to the session bus.
  • Always start the user instance of systemd on a boot.iso for consistency.

The user instance of systemd that we start from Anaconda on the boot.iso runs
a session bus at `XDG_RUNTIME_DIR/bus`. Other services started by Anaconda might
call `bus-launch --autolaunch` to find the existing session bus (or start a new
one), but `dbus-launch` ignores the `XDG_RUNTIME_DIR` environment variable.

* Let's set the `DBUS_SESSION_BUS_ADDRESS` environment variable to fix that.
* Create the `SessionBus` object for an easy access to the session bus.
* Always start the user instance of systemd on a boot.iso for consistency.
Copy link
Contributor

@jexposit jexposit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I tested it intensively in #5463

Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jkonecny12
Copy link
Member

/packit build

@poncovka
Copy link
Contributor Author

poncovka commented Feb 8, 2024

/kickstart-test --testtype smoke

Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well, thanks a lot! :)

@jkonecny12
Copy link
Member

/packit build

@poncovka poncovka merged commit c949c03 into rhinstaller:master Feb 9, 2024
18 checks passed
@jexposit jexposit mentioned this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants