Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F40: Lower permissions for kickstart logs in /tmp #5478

Merged

Conversation

jkonecny12
Copy link
Member

These logs could potentially contain sensitive data so let's set these logs as accessible by root only.

This is extension to #5466 .

@jkonecny12
Copy link
Member Author

/kickstart-test --testtype smoke

Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. :)

@jkonecny12
Copy link
Member Author

/kickstart-test --testtype smoke

@jkonecny12
Copy link
Member Author

/kickstart-test --testtype smoke

1 similar comment
@rvykydal
Copy link
Contributor

/kickstart-test --testtype smoke

@rvykydal
Copy link
Contributor

rvykydal commented Feb 28, 2024

The reason for failing kickstart tests:

[Wed, 28 Feb 2024 12:53:17 virt-install 604] ERROR (cli:257).
--os-variant/--osinfo OS name is required, but no value was
set or detected.

This is now a fatal error. Specifying an OS name is required
for modern, performant, and secure virtual machine defaults.

If you expected virt-install to detect an OS name from the
install media, you can set a fallback OS name with:

  --osinfo detect=on,name=OSNAME
  
You can see a full list of possible OS name values with:

   virt-install --osinfo list

If your Linux distro is not listed, try one of generic values
such as: linux2022, linux2020, linux2018, linux2016

If you just need to get the old behavior back, you can use:

  --osinfo detect=on,require=off

Or export VIRTINSTALL_OSINFO_DISABLE_REQUIRE=1

[Wed, 28 Feb 2024 12:53:17 virt-install 746] DEBUG (cli:256)   File "/usr/bin/virt-install", line 8, in <module>
    virtinstall.runcli()
  File "/usr/share/virt-manager/virtinst/virtinstall.py", line 1233, in runcli
    sys.exit(main())
  File "/usr/share/virt-manager/virtinst/virtinstall.py", line 1220, in main
    guest, installer = build_guest_instance(conn, options)
  File "/usr/share/virt-manager/virtinst/virtinstall.py", line 654, in build_guest_instance
    installer_detect_distro(guest, installer, osdata)
  File "/usr/share/virt-manager/virtinst/virtinstall.py", line 614, in installer_detect_distro
    fail(fail_msg)
  File "/usr/share/virt-manager/virtinst/cli.py", line 256, in fail
    log.debug("".join(traceback.format_stack()))

(kstest.virt-install.log)

@rvykydal
Copy link
Contributor

/kickstart-test --testtype smoke

These logs could potentially contain sensitive data so let's set these
logs as accessible by root only.

(cherry picked from commit 20082d6)
@jkonecny12
Copy link
Member Author

/kickstart-test --testtype smoke

@jkonecny12 jkonecny12 merged commit 1d41a7a into rhinstaller:fedora-40 Mar 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants