Do not mark ancestors of device with source or stage2 as protected #5811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: RHEL-35701 I am not able to find any reason why we started to protect also ancestors of the devices in this case (ie disk in case of source on a partition). The change (marking also ancestors of protected devices as protected in general) was introduced during modularization of Payload. commit 93fdbff commit 26de57d commit 19703fc commit 71dda92 The patch tries to limit the changes to the case of the issue. From what I was able to look at it seems that it should be OK not to include ancestors also in other cases. Cherry-picked from master commit 4779d5f
KKoukiou
requested review from
rvykydal and
jkonecny12
and removed request for
rvykydal
|
/kickstart-test --testtype smoke |
KKoukiou
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: RHEL-35701
I am not able to find any reason why we started to protect also ancestors of the devices in this case (ie disk in case of source on a partition).
The change (marking also ancestors of protected devices as protected in general) was introduced during modularization of Payload.
commit 93fdbff
commit 26de57d
commit 19703fc
commit 71dda92
The patch tries to limit the changes to the case of the issue. From what I was able to look at it seems that it should be OK not to include ancestors also in other cases.
Cherry-picked from master commit 4779d5f