Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the not-satellite: prefix for server hostname #5828

Merged

Conversation

M4rtinK
Copy link
Contributor

@M4rtinK M4rtinK commented Aug 14, 2024

Support the not-satellite: prefix for the server hostname RHSM value. This is cherry-picked from the upcoming Satellite support backport PR and makes it possible to run downstream integration tests without unnecessary changes (as RHEL 9 systems require this prefix for staging CDN testing).

Related: RHEL-49661

@M4rtinK M4rtinK force-pushed the rhel-10-support_not_satellite_prefix branch 2 times, most recently from 7331110 to bf95c73 Compare August 14, 2024 14:56
@M4rtinK
Copy link
Contributor Author

M4rtinK commented Aug 14, 2024

/kickstart-test --testtype smoke

@M4rtinK
Copy link
Contributor Author

M4rtinK commented Aug 15, 2024

/build-image --boot.iso

Copy link

Images built based on commit bf95c73:

  • boot.iso: success

Download the images from the bottom of the job status page.

Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please first we should try to resolve the test question.

@M4rtinK M4rtinK force-pushed the rhel-10-support_not_satellite_prefix branch from bf95c73 to 8172f72 Compare August 15, 2024 12:19
@pep8speaks
Copy link

pep8speaks commented Aug 15, 2024

Hello @M4rtinK! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-08-15 12:53:04 UTC

Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Support the not-satellite: prefix for the server hostname RHSM value.
This is cherry-picked from the upcoming Satellite support backport PR and
makes it possible to run downstream integration tests without unnecessary changes
(as RHEL 9 systems require this prefix for staging CDN testing).

Related: RHEL-49661
@M4rtinK M4rtinK force-pushed the rhel-10-support_not_satellite_prefix branch from 8172f72 to ae46ee8 Compare August 15, 2024 12:52
@M4rtinK
Copy link
Contributor Author

M4rtinK commented Aug 15, 2024

/kickstart-test --testtype smoke

@M4rtinK M4rtinK added the ready to merge The PR can be merged. It should have all BZ flags required for releasing set (usually release+). label Aug 15, 2024
@M4rtinK M4rtinK merged commit 596389e into rhinstaller:rhel-10 Aug 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port to Fedora ready to merge The PR can be merged. It should have all BZ flags required for releasing set (usually release+). rhel-10
Development

Successfully merging this pull request may close these issues.

3 participants