Drop Xorg server and libxklavier #5829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkonecny12
added
blocked
jkonecny12
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
github-actions
bot
added
the
infrastructure
jkonecny12
force-pushed
the
master-wayland-migration
branch
from
ad35ee3
to
11f1d1c
Compare
jkonecny12
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
jkonecny12
force-pushed
the
master-wayland-migration
branch
from
11f1d1c
to
74731a2
Compare
jkonecny12
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
|
Hello @jkonecny12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-10-09 08:19:10 UTC |
jkonecny12
force-pushed
the
master-wayland-migration
branch
from
74731a2
to
5df56e1
Compare
jkonecny12
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
jkonecny12
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
|
Add #5842 on top of the pile. |
jkonecny12
added
f42
jkonecny12
force-pushed
the
master-wayland-migration
branch
from
71aad99
to
7931f1f
Compare
jkonecny12
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
Can we please put the VNC stuff back? GRD supports VNC and RDP, and there are many more high quality VNC clients than there are RDP clients for Linux. And even the first party Mac remote desktop client is VNC-based, not RDP. |
jkonecny12
force-pushed
the
master-wayland-migration
branch
from
7931f1f
to
4128034
Compare
jkonecny12
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
@Conan-Kudo as said a few times. I won't do that from start. This is already quite heavy patch set and getting into this VNC would make it just heavier. Also based on the GRD maintainer reply it doesn't sound wise move in the current situation https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/G4DFKOUDDDDYHNQBNYRH52XVYKWK5X2U/ |
|
Added support for localed. Unfortunately we can't merge this until this is resolved https://pagure.io/releng/issue/12275 because it's blocking one of our new dependency. |
|
Also I need to do testing on Live to find how it behaves there. |
jkonecny12
force-pushed
the
master-wayland-migration
branch
from
4128034
to
4583972
Compare
jkonecny12
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
|
UPDATED:
|
Because of the switch to Wayland Anaconda has to change compositor keyboard manager because libxklavier doesn't work on Wayland. To fix that we migrated to Gnome Kiosk DBus API in RHEL-10, however, this solution can't be used outside of Gnome Kiosk. For that reason, we are switching to Localed which we set as the default to enable Anaconda to control keyboard switching.
This code is not used since migration to Wayland. We need another solution for this feature.
The GRDServer class have checks in the __init__ method which starts to complain about missing GRD in the system. That doesn't apply in Live environment where we don't support GRD in the first place.
This logic was used to disable keyboard switching for given system. However, we we support even Wayland systems with the new solution, so let's remove this.
Previously it was vnc but we switched to RDP instead.
If Anaconda will set keyboard layouts to compositor but options are missed then we shouldn't change the compositor options but rather use what is already set. This will avoid problematic behavior of changing what user has defined in the system or similar cases. Also we have this tested in kickstart-tests, so this commit is fixing these tests. Also fix existing tests and cover this functionality by tests.
We need to disable these repositories to avoid dependencies from it. With this changeset we depends on gnome-remote-desktop which depends on librdp which depends (Fedora only) on openh264. However, if fedora-cisco repository is not enabled it will instead install noopenh264 package which is a stub package in the main repositories.
Move the GRDServer class creation to the end of the `setup_display` method. This class have checks for binaries in the `__init__` method which is causing early failures. Also do not create the class if it is not really used.
The Wayland/RDP support broke the installer running on s390x z/VM and LPAR. Resolves: RHEL-45516 (cherry picked from commit 931dea5)
jkonecny12
force-pushed
the
master-wayland-migration
branch
from
db576ec
to
621a852
Compare
jkonecny12
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
UPDATED:
|
|
/kickstart-test --testtype smoke |
|
/kickstart-test --kstest-pr 1309 ui_rdp |
|
/kickstart-test --skip-testtypes whatever |
KKoukiou
pushed a commit
to KKoukiou/anaconda-webui
that referenced
this pull request
Oct 9, 2024
There is a new patchset to migrate Anaconda to Wayland native application. This patchset is unfortunately quite big and complicated. rhinstaller/anaconda#5829 Current Web UI testing depends on updates image creation from the Anaconda RPMs which are downloaded from Rawhide and/or COPR repos. However, we are hitting issues for updates images in this case. - Removal of spoke in Anaconda will not be covered by updates image. This is expected because RPM don't have information that some file was removed. Usually this is not an issue because the removed code is not imported. Unfortunately, here the code is imported by our dynamic spoke importer. That will result in traceback because of missing imports in the removed spoke. - The patchset in Anaconda is adding new dependencies required to be able to start the Wayland environment, however, these are not covered when an updates image is created because we can't tell which deps are new and should be part of the ISO. We should resolve this somehow by improving the workflow in the future. For now we can continue with this hotfix.
jkonecny12
added a commit
to jkonecny12/anaconda-webui
that referenced
this pull request
Oct 9, 2024
There is a new patchset to migrate Anaconda to Wayland native application. This patchset is unfortunately quite big and complicated. rhinstaller/anaconda#5829 Current Web UI testing depends on updates image creation from the Anaconda RPMs which are downloaded from Rawhide and/or COPR repos. However, we are hitting issues for updates images in this case. - Removal of spoke in Anaconda will not be covered by updates image. This is expected because RPM don't have information that some file was removed. Usually this is not an issue because the removed code is not imported. Unfortunately, here the code is imported by our dynamic spoke importer. That will result in traceback because of missing imports in the removed spoke. - The patchset in Anaconda is adding new dependencies required to be able to start the Wayland environment, however, these are not covered when an updates image is created because we can't tell which deps are new and should be part of the ISO. We should resolve this somehow by improving the workflow in the future. For now we can continue with this hotfix.
|
We have agreed that although the Web UI tests are broken on this PR - we need to merge it - and wait for the new ISO to include the new deps for wayland for the Web UI CI to consume. All the efforts we did to make this work ended unsuccesfully (Manual testing of Web UI happened - it looks fine). |
yselkowitz
added a commit
to yselkowitz/content-resolver-input
that referenced
this pull request
Oct 11, 2024
This was referenced Oct 11, 2024
|
For the reference, these kickstart-test flakes / issues started to appear also on daily-iso after merge of the PR (used to be seen only on rhel-10 before): |
yselkowitz
added a commit
to yselkowitz/content-resolver-input
that referenced
this pull request
Oct 20, 2024
yselkowitz
added a commit
to minimization/content-resolver-input
that referenced
this pull request
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is port of the:
It is first part of the Wayland migration patches to Fedora.
Resolves: https://fedoraproject.org/wiki/Changes/Anaconda_As_Native_Wayland_Application
TODO:
Ready for review
After this merge
Drop VNC from the DBus API backend- let's leave this for later based on the initiative to get VNC back