infra: Remove use of host network in containers #5831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have added this to cover VPN access where containers run as root don't have access to VPN network. However, it makes a mess elsewhere because the host network configuration could be much harder to predict. To resolve this just give user a heads-up that he might need that and how to enable this feature. However, let's leave things simple and don't use host network if not required.
|
Infrastructure check failed on these files. Please do a double check of these files before merge! Makefile.am |
KKoukiou
approved these changes
Aug 16, 2024
|
/kickstart-test --waive infra only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have added this to cover VPN access where containers run as root don't have access to VPN network. However, it makes a mess elsewhere because the host network configuration could be much harder to predict.
To resolve this just give user a heads-up that he might need that and how to enable this feature. However, let's leave things simple and don't use host network if not required.