Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: Remove centos specific condition form spec #5834

Conversation

jkonecny12
Copy link
Member

Currently we are building CentOS Stream package and using it to build RHEL ISO images. That works fine expect specific CentOS conditions. Let's fix that by modifying spec file before build.

Currently we are building CentOS Stream package and using it to build
RHEL ISO images. That works fine expect specific CentOS conditions.
Let's fix that by modifying spec file before build.

(cherry picked from commit d78ece0)
@jkonecny12
Copy link
Member Author

/kickstart-test --waive infra only

Copy link
Contributor

@KKoukiou KKoukiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont understand this change to be honest.
I see it's about subscription-manager. If we install the anaconda centos RPM to the RHEL ISO it's fine, subscription-manager will be there and the spoke will be available regardless of the spec file requires.

Can you please explain me where I am wrong?

@jkonecny12
Copy link
Member Author

The subscrition-manager is not there (reported by @M4rtinK). The problem is that we build the RPM in CentOS Stream and our spec file has this
https://github.com/rhinstaller/anaconda/blob/master/anaconda.spec.in#L112

%if %{defined rhel} && %{undefined centos}
Requires: subscription-manager >= %{subscriptionmanagerver}
%endif

I wasn't aware of that but these conditions are resolved during package build. So our RPM without this change don't have Requires: subscription-manager which means that when we build RHEL ISO even that the Anaconda works the ISO won't have the subscription-manager at all.

@KKoukiou
Copy link
Contributor

KKoukiou commented Aug 19, 2024

The subscrition-manager is not there (reported by @M4rtinK). The problem is that we build the RPM in CentOS Stream and our spec file has this https://github.com/rhinstaller/anaconda/blob/master/anaconda.spec.in#L112

%if %{defined rhel} && %{undefined centos}
Requires: subscription-manager >= %{subscriptionmanagerver}
%endif

I wasn't aware of that but these conditions are resolved during package build. So our RPM without this change don't have Requires: subscription-manager which means that when we build RHEL ISO even that the Anaconda works the ISO won't have the subscription-manager at all.

I see it there in centos stream 10 https://mirror.stream.centos.org/10-stream/BaseOS/x86_64/os/Packages/.

Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. :)

Copy link
Contributor

@KKoukiou KKoukiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@jkonecny12 jkonecny12 merged commit 0af4444 into rhinstaller:rhel-9 Aug 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants