pyanaconda: remove code paths around module command parsing as this was deprecated #5845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKoukiou
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
KKoukiou
force-pushed
the
module-deprecation
branch
from
2889682
to
8d9f0b7
Compare
KKoukiou
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
KKoukiou
force-pushed
the
module-deprecation
branch
from
8d9f0b7
to
92a67c0
Compare
KKoukiou
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
KKoukiou
force-pushed
the
module-deprecation
branch
from
92a67c0
to
a722144
Compare
KKoukiou
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
KKoukiou
force-pushed
the
module-deprecation
branch
from
a722144
to
329e98a
Compare
KKoukiou
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
…as deprecated Remove also the related tests as these are no longer relevant. Also bump the pykickstart required version which marks 'module' as Deprecated.
KKoukiou
force-pushed
the
module-deprecation
branch
from
329e98a
to
6844c12
Compare
KKoukiou
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
M4rtinK
approved these changes
Aug 21, 2024
| @@ -302,6 +267,7 @@ class PayloadKickstartSpecification(KickstartSpecification): | |||
| commands_data = { | |||
| "ModuleData": COMMANDS.ModuleData, | |||
| "RepoData": COMMANDS.RepoData, | |||
|
|
|||
There was a problem hiding this comment.
I think this might be a typo/leftover ? :)
There was a problem hiding this comment.
I think we can also remove these once it pykickstart it gets to RemovedCommand.
I tried removing it and I got ~50 tests failures.
KKoukiou
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
KKoukiou
force-pushed
the
module-deprecation
branch
from
0c92ede
to
7ea147c
Compare
KKoukiou
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
|
/kickstart-tests --testtype smoke |
KKoukiou
force-pushed
the
module-deprecation
branch
from
7ea147c
to
6a65673
Compare
KKoukiou
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
|
/kickstart-tests --testtype smoke |
vojtechtrefny
approved these changes
Aug 21, 2024
KKoukiou
force-pushed
the
module-deprecation
branch
from
6a65673
to
6eae79c
Compare
KKoukiou
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
|
/kickstart-tests --testtype smoke |
KKoukiou
force-pushed
the
module-deprecation
branch
from
6eae79c
to
255280d
Compare
KKoukiou
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
|
/kickstart-tests --testtype smoke |
|
The builds where successful - click links to see. There was some hickups with github events, therefore status was not updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove also the related tests as these are no longer relevant.