infra: Remove unnecessary deps from install deps #5854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/kickstart-test --waive infra only |
KKoukiou
reviewed
Aug 27, 2024
One of the biggest use cases for the install_dependencies.sh script is to get dependencies to the container for development easily. However, container management services are not usable from the container directly and are not helpful for development (just development dependency). Having these in the container could block easy way to call binaries from inside of the container in similar cases like `distrobox-host-exec` which enables you to call container commands (allows our make commands) from inside of the distrobox container. Others are just wrong to be installed on developer machine for example gnome-kiosk.
Without a git the `make` call will fail because we are downloading localization data from external repository.
jkonecny12
force-pushed
the
master-tweak-install-dependencies-script
branch
from
79a95bf
to
dcafb79
Compare
|
UPDATED
|
|
/kickstart-test --waive infra only |
KKoukiou
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the biggest use cases for the install_dependencies.sh script is to get dependencies to the container for development easily. However, container management services are not usable from the container directly and are not helpful for development (just development dependency).
Having these in the container could block easy way to call binaries from inside of the container in similar cases like
distrobox-host-execwhich enables you to call container commands (allows our make commands) from inside of the distrobox container.Others are just wrong to be installed on developer machine for example gnome-kiosk.
Replacement of #5844 .