Fix check for biosboot partition in GRUB2.check #5874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For partitions scheduled to be created the PARTITION_BIOS_GRUB flag is not yet set so we can't use it to check for the biosboot partition presence.
vojtechtrefny
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
KKoukiou
approved these changes
Sep 13, 2024
|
/kickstart-tests --testtype smoke |
This was referenced Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For partitions scheduled to be created the PARTITION_BIOS_GRUB flag is not yet set so we can't use it to check for the biosboot partition presence.
Unfortunately I wasn't really able to test this because this requires creating a partition starting on offset 34 to trigger this check which is generally not possible (we have a customer with a special hardware where this happens), but the change is relatively simple so it hopefully shouldn't break anything.