Fixes for unblocking RHEL-10 container builds #5889
Merged
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will unblock container refreshes. This affects also RHEL. Related: https://bugzilla.redhat.com/show_bug.cgi?id=2295428 Related: https://issues.redhat.com/browse/RHEL-46558 Cherry-picked from master branch commit: 56e0269.
github-actions
bot
added
infrastructure
|
/kickstart-tests --waive unit tests covered |
M4rtinK
approved these changes
Sep 20, 2024
| @@ -169,7 +169,7 @@ def test_get_default_file_system(self): | |||
| def test_get_supported_raid_levels(self): | |||
| """Test GetSupportedRaidLevels.""" | |||
| assert self.interface.GetSupportedRaidLevels(DEVICE_TYPE_MD) == \ | |||
| ['linear', 'raid0', 'raid1', 'raid10', 'raid4', 'raid5', 'raid6'] | |||
There was a problem hiding this comment.
Is this intended to be there ? I find it strange this is part of an infra PR ?
There was a problem hiding this comment.
Well it's not an infra PR.
It's a PR with some fixes that are needed to re-enable building centos10 and centos9 containers
There was a problem hiding this comment.
Even the 'infra' marked commit - has tests changes.
KKoukiou
changed the title
|
infra check is naive - checking per-pr - not per-commit validity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will unblock container refreshes.
This affects also RHEL.
Related: https://bugzilla.redhat.com/show_bug.cgi?id=2295428
Related: https://issues.redhat.com/browse/RHEL-46558
Cherry-picked from master branch commit: 56e0269.