Prepare kickstart tests to handle the switch from VNC to RDP #1175
Conversation
M4rtinK
force-pushed
the
master-handle_rdp_changes
branch
from
353e8e4
to
9059d67
Compare
|
/test-os-variants |
|
/test-os-variants |
|
Looks like the tests are still running on anaconda-40.22.3.4, while we need anaconda-40.22.3.5. So lets wait a bit more. :) |
|
/test-os-variants |
|
|
||
| systemctl get-default | grep multi-user.target | ||
| if [[ $? != 0 ]]; then | ||
| echo "*** multi-user.target should be set for VNC installs even is package with service(graphical-login) is installed" >> /root/RESULT |
There was a problem hiding this comment.
"for remote desktop (RDP) installs"?
a typo "even is" -> "even if" ?
There was a problem hiding this comment.
Fixed - thanks! :)
ui_rdp.ks.in
Outdated
| # Check the installation mode. | ||
| check_display_mode "interactive graphical mode" | ||
|
|
||
| # Check the VNC server. |
|
Apart from a few obsolete comments looks good to me, thank you. I already disabled the vnc tests on rhel10 in #1234 so the PR needs update for it. |
Test the new RDP based remote desktop support that gets in together with the Wayland support patches. NOTE: Right now we are testing that RDP server is running and and default system target is set correctly. But we are not yet testing if it is actually possible to connect to the RDP session with a client.
M4rtinK
force-pushed
the
master-handle_rdp_changes
branch
from
9059d67
to
5bb5d6e
Compare
|
Updated with fixes as suggested, dropped the VNC disable commit & rebased. :) |
|
/test-os-variants |
|
The fail of travis test should be fixed in a separate issue. The test should be ignored on master (travis test), which seems to happen, but a failure is wrongly reported. I'll look into it. |
|
/test-os-variants |
The first commit disables VNC test on RHEL 10, while the second commit adds RDP version of the tests that are currently marked no to run on Fedora.
NOTE: Do not merge before the Wayland support PRs are merged!
Wayland PRs:
rhinstaller/anaconda#5463
rhinstaller/anaconda#5470
rhinstaller/anaconda#5485
rhinstaller/anaconda#5498