Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aws-nuke staling when there are a lot of S3Objects #101

Merged
merged 5 commits into from
Dec 12, 2024
Merged

Conversation

fridim
Copy link
Contributor

@fridim fridim commented Dec 12, 2024

GPTEINFRA-12752

  • aws-nuke stale: when the account to cleanup has a lot of S3objects, with current config aws-nuke loops and fails.
    => In the config, exclude S3Object entirely, because S3 bucket removal handles removing all S3Objects already.
  • Cost savings: in case of any aws-nuke failure, stop all EC2 instances to save costs
  • bump aws-nuke to latest stable version v3.35.2
  • add ansible.cfg with profile_tasks to gather execution time of tasks

When there are a large number of s3object, aws-nuke fails

Excluded because S3 bucket removal handles removing all S3Objects
@fridim fridim marked this pull request as draft December 12, 2024 09:37
@fridim fridim marked this pull request as ready for review December 12, 2024 10:57
Copy link
Contributor

@agonzalezrh agonzalezrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@fridim fridim merged commit a4fdd22 into main Dec 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants