Todomvc create react app es6

[amitnovick]

Hi whitefire0,

I've just yesterday noticed that I was working on a branch that was behind several changes you mentioned in TodoMVC #1857.

So today I brought all the changes in my PRs #1, #2, #3 that were on master, into this branch (todomvc-create-react-app-es6).

However there is one issue where it seems that you added changes to the CSS file index.css at the third-party npm package: todomvc-app-css.

Apparently the changes solve a UI issue where the ToggleAll checkbox input element does not exist.

Here I list the changes:

/* before */

.toggle-all {
	text-align: center;
	border: none; /* Mobile Safari */
	opacity: 0;
	position: absolute;
}

.toggle-all + label {
	width: 60px;
	height: 34px;
	font-size: 0;
	position: absolute;
	top: -52px;
	left: -13px;
	-webkit-transform: rotate(90deg);
	transform: rotate(90deg);
}

.toggle-all + label:before {
	content: '❯';
	font-size: 22px;
	color: #e6e6e6;
	padding: 10px 27px 10px 27px;
}

.toggle-all:checked + label:before {
	color: #737373;
}

@media screen and (-webkit-min-device-pixel-ratio:0) {
	.toggle-all,
	.todo-list li .toggle {
		background: none;
	}

	.todo-list li .toggle {
		height: 40px;
	}
}

/* after */

.toggle-all {
	position: absolute;
	top: -55px;
	left: -12px;
	width: 60px;
	height: 34px;
	text-align: center;
	border: none;
	-webkit-transform: rotate(90deg);
	transform: rotate(90deg);
}

.toggle-all:before {
	content: '❯';
	font-size: 22px;
	color: #e6e6e6;
	padding: 10px 27px 10px 27px;
}

.toggle-all:checked:before {
	color: #737373;
}

@media screen and (-webkit-min-device-pixel-ratio:0) {
	.toggle-all {
		-webkit-transform: rotate(90deg);
		transform: rotate(90deg);
		-webkit-appearance: none;
		appearance: none;
 }
	.todo-list li .toggle {
		background: none;
	}

	.todo-list li .toggle {
		height: 40px;
	}
}

This is a problem since this package is supposed to be shared by all TodoMVC implementation projects AFAIK, such that each implementation uses this same CSS file.

There are two ways to solve this problem:

1. Remove the changes made to todomvc-app-css/index.css and apply these changes locally in the /examples/react project.
2. Convince the maintainers of todomvc-app-css to adopt these changes and publish a version that includes them, and specify this new version in package.json.

I would like to hear your thoughts on this matter or on my changes.
Regards