Skip to content

Commit

Permalink
Merge pull request #37 from Seb-sti1/value-error
Browse files Browse the repository at this point in the history
Fix #16
  • Loading branch information
ricklupton authored Dec 3, 2024
2 parents 68203f7 + ffcc16f commit bb61d8a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ To convert rm files to other formats, you can use [rmc](https://github.com/rickl
Fixes:

- Fix AssertionError when some ids are missing in a `CrdtSequence` ([#36](https://github.com/ricklupton/rmscene/pull/36))
- Fix ValueError when the node_id is missing in a `SceneGroupItemBlock` ([#16](https://github.com/ricklupton/rmscene/issues/16))
- Store any unparsed data in blocks as raw bytes to allow for round-trip saving of files written in a newer format than the parsing code knows about.

### v0.6.0
Expand Down
2 changes: 2 additions & 0 deletions src/rmscene/scene_stream.py
Original file line number Diff line number Diff line change
Expand Up @@ -886,6 +886,8 @@ def build_tree(tree: SceneTree, blocks: Iterable[Block]):
elif isinstance(b, SceneGroupItemBlock):
# Add this entry to children of parent_id
node_id = b.item.value
if node_id is None:
continue
if node_id not in tree:
raise ValueError(
"Node does not exist for SceneGroupItemBlock: %s" % node_id
Expand Down

0 comments on commit bb61d8a

Please sign in to comment.