Security 2.1.1 - Tx and RX #230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 22, 2024 12:58
|
Looks good after a first quick review :-) |
|
Yes, it was sometimes tricky with all the pointer declarations, but that is what makes it interesting. If it needs any improvement whatsoever, please let me know. |
|
I have rebased your PR and merged it into the master branch now. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
For my project which uses Vanetza, I needed to implement secure message sending. I've implemented the DummySignService and the StraightSignService. While I don't think it's ready yet for integration into the master branch, I would appreciate your feedback on this implementation. I've tested it using socketap and it seems to be working fine.
Thank you!