Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ksud: fix /debug_ramdisk not mounting #68

Draft
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

bryanyee33
Copy link

@bryanyee33 bryanyee33 commented Jan 3, 2025

Bring back mount_tmpfs() in
https://github.com/tiann/KernelSU/blob/a3df721b845f288a731916fc7777efeefb033af7/userspace/ksud/src/mount.rs#L158
to allow both legacy and new implementations.

This fixes /debug_ramdisk not mounting for certain devices on magic mount.

Reference to original usage in KernelSU:
https://github.com/tiann/KernelSU/blob/69f31abd62e4f275bb33c9b478961d09231f154d/userspace/ksud/src/init_event.rs#L194

mount.rs which was brought back in bff23c6 is now unused so it can also be safely removed.

@bryanyee33 bryanyee33 force-pushed the kernelsu-next branch 3 times, most recently from 86cd7d9 to a02054c Compare January 3, 2025 13:50
Bring back mount_tmpfs() in
https://github.com/tiann/KernelSU/blob/a3df721b845f288a731916fc7777efeefb033af7/userspace/ksud/src/mount.rs#L158
to allow both legacy and new implementations.

This fixes /debug_ramdisk not mounting for certain devices on magic mount.

Reference to original usage in KernelSU:
https://github.com/tiann/KernelSU/blob/69f31abd62e4f275bb33c9b478961d09231f154d/userspace/ksud/src/init_event.rs#L194
@bryanyee33 bryanyee33 marked this pull request as draft January 3, 2025 16:02
@rifsxd
Copy link
Owner

rifsxd commented Jan 5, 2025

@bryanyee33
Copy link
Author

No that commit is to allow toggling of mounting /debug_ramdisk.
Some users do not have /debug_ramdisk mounted on boot, and are unable to add/modify files inside even with root.
The error shows up as "Read-only file system" instead
of "Permission denied", showing that the mount is not simply hidden.

I've got 2 different methods to possibly fix it currently:
bryanyee33@b8e38b7
bryanyee33@f2dedcc

but the user with the issue has not gotten back to me yet.

@rifsxd
Copy link
Owner

rifsxd commented Jan 5, 2025

when you've finished testing and debugging this issue then let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants