Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: Devcontainer/codespaces support #1511

Closed
wants to merge 8 commits into from
Closed

New: Devcontainer/codespaces support #1511

wants to merge 8 commits into from

Conversation

bramathon
Copy link
Contributor

Description

Added infrastructure to use VSCode devcontainers and Codespaces.

Updated the Dockerfile and made it appropriate for containerized development.

Updated docker-compose file for containerized development.

Added .devcontainer folder.

Checklist

  • The PR targets the master branch
  • The above description motivates these changes.
  • The change is atomic and can be described by a single commit (your PR will be squashed on merge).
  • All changes to code are covered via unit tests.
  • Parameters and return values have type hints with PEP 484 syntax.
  • Functions and classes have useful Sphinx-style docstrings.
  • (New Feature) The docs have been updated accordingly.
  • (Bugfix) The associated issue is referenced above using auto-close keywords.

@bramathon bramathon requested a review from a team as a code owner December 12, 2022 17:44
@bramathon bramathon changed the title Feature/devcontainer New: Devcontainer/codespaces support Dec 14, 2022
notmgsk
notmgsk reviewed Jan 16, 2023
View reviewed changes
docker-compose.yml Outdated Show resolved Hide resolved
@bramathon
Copy link
Contributor Author

bump

MarquessV
MarquessV reviewed Jun 29, 2023
View reviewed changes
Copy link
Contributor

@MarquessV MarquessV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions, but looks like it's nearly there.

Dockerfile Outdated Show resolved Hide resolved
poetry.lock Outdated Show resolved Hide resolved
@bramathon
Copy link
Contributor Author

Closing this in favour of a PR to V4

@bramathon bramathon closed this Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genos genos genos left review comments

@notmgsk notmgsk notmgsk left review comments

@MarquessV MarquessV MarquessV approved these changes

@kalzoo kalzoo kalzoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bramathon @genos @MarquessV @notmgsk @kalzoo