Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused dependencies and remove Cargo.lock #348

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Remove unused dependencies and remove Cargo.lock #348

wants to merge 4 commits into from

Conversation

notmgsk
Copy link
Contributor

@notmgsk notmgsk commented Aug 22, 2023 •
edited
Loading

Closes #347 and closes #319. Also fixes an issue with the dirs package using a disallowed licence (MPL-2.0).

@notmgsk notmgsk requested a review from MarquessV August 22, 2023 13:06
@notmgsk notmgsk marked this pull request as ready for review August 22, 2023 13:06
@notmgsk notmgsk changed the title Remove unused qcs-api dependency and remove Cargo.lock Remove unused dependencies and remove Cargo.lock Aug 22, 2023
@notmgsk
Copy link
Contributor Author

notmgsk commented Aug 22, 2023 •
edited
Loading

There are more issues arising from cargo-deny:

  • Advisory: https://rustsec.org/advisories/RUSTSEC-2023-0052. webpki is pulled in by rustls, tokio-rustls, hyper-proxy, and hyper-rustls, the latter two of which mark webpki as optional. tokio-rustls version 0.24.1 uses rustls-webpki which has resolved the advisory. rustls will use rustls-webpki in its next release.
  • found 2 duplicate entries for crate 'windows-sys'. I would just change these to warnings.

@Shadow53 @MarquessV thoughts?

@notmgsk notmgsk requested a review from Shadow53 August 22, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarquessV MarquessV Awaiting requested review from MarquessV

@Shadow53 Shadow53 Awaiting requested review from Shadow53

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unused qcs-api dependency Don't track Cargo.lock
1 participant
@notmgsk