fix(logger): fix logger storage issue for key already exists #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZouYouShun
reviewed
Jul 10, 2024
| this._savingLogs.add(data); | ||
| data.time = await this._checkTimeKey(data.time); |
There was a problem hiding this comment.
so from now every time will reget value from DB storage
what is the time be use?
There was a problem hiding this comment.
This "time" refers to the initialization time of each log entry. It means that every time a write is made to the DB, this "time" will be set in memory as the value for a new log entry using the current time.
It's different from a session, which is a value for a single runtime.
The "time" field here is used for index querying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.