Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replica exchange simulation submission + minor reeds tweaks #288

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

candidechamp
Copy link
Collaborator

@candidechamp candidechamp commented Apr 11, 2022

I reimplemented (and re-tested) the changes in #222 (as I didn't want to have trouble with merge conflicts, although they all seemed super minor and would have been easily fixed).

The code in here is essentially the same as in #222 with the exception of some imd related functions, where I simplified a call to str2bool (previously was put in an if, else block based on input given to function, which already happens in the function).

To do

  • Pre-commit passed

Status

  • Ready to go

PS: Please don't delete the pygromos3_for_reeds branch after merge. I would like to keep this branch in parallel at all times (and probably also have a "release" for it so that there is an easily accessible version for RE-EDS users once I have implemented all I need to).

@candidechamp candidechamp mentioned this pull request Apr 11, 2022
2 tasks
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #288 (efa11f8) into main (53767f5) will decrease coverage by 0.01%.
The diff coverage is 15.51%.

@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
- Coverage   54.14%   54.12%   -0.02%     
==========================================
  Files          93       93              
  Lines       14285    14279       -6     
==========================================
- Hits         7734     7728       -6     
  Misses       6551     6551              
Flag Coverage Δ
unittests 54.12% <15.51%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pygromos/files/simulation_parameters/imd.py 64.80% <ø> (-0.05%) ⬇️
...orkers/simulation_workers/simulation_run_worker.py 9.81% <0.00%> (-2.89%) ⬇️
pygromos/files/blocks/imd_blocks.py 78.89% <58.33%> (+2.59%) ⬆️
pygromos/utils/utils.py 76.03% <100.00%> (+3.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53767f5...efa11f8. Read the comment docs.

@candidechamp
Copy link
Collaborator Author

@MTLehner I think you can merge the code now (you probably want to checkout and submit a quick calculation just to make sure everything is fine on your end).

@candidechamp candidechamp requested a review from MTLehner May 9, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant