Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elaborate on trace related sideband signal #48

Closed
AoteJin opened this issue Jul 23, 2024 · 4 comments
Closed

Elaborate on trace related sideband signal #48

AoteJin opened this issue Jul 23, 2024 · 4 comments
Assignees

Comments

@AoteJin
Copy link
Collaborator

AoteJin commented Jul 23, 2024

  • Document the desired trace behavior relative to the trace sideband signal values.
  • Align the naming of the signals
@bcstrongx
Copy link
Collaborator

In the discussion linked above, I made two suggestions:

  1. Remove any reference to the hart-to-encoder interface (including new signals proposed for it) from the Sdsec spec, since it is purely an implementation detail and there is no mandated implementation. An architecture spec should refer only to behavior based on architectural values (like mtrcen and sdetrcalw). The interface is also being removed from the trace spec, and moved to a whitepaper.

  2. In the hart-to-encoder whitepaper, call the new signal sec_inhibit rather than sec_check, since it serves to inhibit trace when set.

@AoteJin
Copy link
Collaborator Author

AoteJin commented Jul 30, 2024

The sdsec will follow suggestion in https://lists.riscv.org/g/tech-external-debug-security/message/124 to add descriptive content on architectural state, leaving out the interface details.

@AoteJin
Copy link
Collaborator Author

AoteJin commented Aug 6, 2024

Hi Beeman, I updated the description of the trace in PR #53. Could you help review it?

@AoteJin
Copy link
Collaborator Author

AoteJin commented Aug 13, 2024

closing with PR #53 submitted.

@AoteJin AoteJin closed this as completed Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants