Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update based on Rev0.5 feedbacks #47

Merged
merged 51 commits into from
Jul 30, 2024
Merged

Update based on Rev0.5 feedbacks #47

merged 51 commits into from
Jul 30, 2024

Conversation

AoteJin
Copy link
Collaborator

@AoteJin AoteJin commented Jul 2, 2024

  • Wording update
    • Typo fixes
    • General update to improve clearance
    • Replace "submachine" to "supervisor domain"
    • Replace "machine mode" to "M-mode"
    • Add notes to clarify the scenario when the debug control changes dynamically in section 3.1
    • Add notes to elaborate on dmode in in section 3.3.1
  • Add a list to summarize the changes made to debug and trace spec in chapter 1
  • Add Terminology in section 1.1
  • Abstract Command without halting cause cmderr set to 6 in section 3.1
  • Include memory access without halting behavior in section 3.1
  • Make stepie accessible in debug mode and only affect the interrupt delegated to debug-allowed privilege in section 3.1.5
  • Add description for conditions where triggers are not configurable in section 3.3
  • Define that the external trigger inputs are constrained by source from where it is generated in section 3.3.2
  • Fix access privilege for tcontrol, scontext, hcontext, mcontext, and mscontext in section 3.3.4
  • The dcsr fields access rule is determined by debug control knobs instead of debug access privilege in section 3.4.1
  • Extend and the extension discovery method in section 4.1
  • Halt-on-reset will be pending till first debuggable instruction in section 4.3
  • Keepalive will not raise error in section 4.4
  • Change error status to be sticky and add acksecfault bit to clear error status in section 4.7
  • Change spec name from "RISC-V External Debug Security Extension" to "RISC-V External Debug Security Specification"
  • Update copyright
  • Update reference

Aote Jin and others added 30 commits June 3, 2024 11:11
- Update the wording and add change overview in intro
- Update the wording and reference
Fix some wordings according to feedback
Signed-off-by: Aote Jin <aotej@nvidia.com>
- Wording update for non-ISA extension
@joxie joxie marked this pull request as ready for review July 3, 2024 07:33
chapter2.adoc Outdated Show resolved Hide resolved
chapter2.adoc Outdated Show resolved Hide resolved
chapter2.adoc Outdated Show resolved Hide resolved
chapter2.adoc Outdated Show resolved Hide resolved
chapter2.adoc Outdated Show resolved Hide resolved
chapter2.adoc Outdated Show resolved Hide resolved
chapter3.adoc Outdated Show resolved Hide resolved
chapter2.adoc Outdated Show resolved Hide resolved
Generalize to be abstract commands without halting

Co-authored-by: gokhankaplayan <Gokhan.Kaplayan@imgtec.com>
Signed-off-by: Aote Jin <aotej@nvidia.com>
chapter2.adoc Outdated Show resolved Hide resolved
chapter2.adoc Outdated Show resolved Hide resolved
chapter2.adoc Outdated Show resolved Hide resolved
chapter2.adoc Outdated Show resolved Hide resolved
chapter2.adoc Outdated Show resolved Hide resolved
chapter3.adoc Outdated Show resolved Hide resolved
chapter3.adoc Outdated Show resolved Hide resolved
chapter3.adoc Outdated Show resolved Hide resolved
chapter3.adoc Outdated Show resolved Hide resolved
intro.adoc Outdated Show resolved Hide resolved
- Update notes for M-mode debug control mdbgen and trigger firing
- Modify the stepie behavior
- Include memory access without halting behavior
- Modify halt-on-reset, keepalive behavior
- Modify error status bit
- Add acksecfault
- Halt-on-reset will be pending till first debuggable instruction
chapter3.adoc Outdated Show resolved Hide resolved
chapter2.adoc Outdated Show resolved Hide resolved
chapter3.adoc Outdated Show resolved Hide resolved
chapter3.adoc Outdated Show resolved Hide resolved
chapter3.adoc Outdated Show resolved Hide resolved
chapter2.adoc Outdated Show resolved Hide resolved
@AoteJin AoteJin merged commit 531829d into main Jul 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants