Skip to content

Commit

Permalink
editorial update
Browse files Browse the repository at this point in the history
  • Loading branch information
ved-rivos committed Dec 11, 2024
1 parent c93cb6d commit a9b21e7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 12 deletions.
4 changes: 0 additions & 4 deletions src/iommu_in_memory_queues.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -293,10 +293,6 @@ Some implementations may cache an identity-mapped translation for the stage of
address translation operating in `Bare` mode. Since these identity mappings
are invariably correct, an explicit invalidation is unnecessary.
Some implementations may cache an identity-mapped translation for the stage of
address translation operating in `Bare` mode. Since these identity mappings
are invariably correct, an explicit invalidation is unnecessary.
A consequence of this specification is that an implementation may use any
translation for an address that was valid at any time since the most recent
`IOTINVAL` that subsumes that address. In particular, if a leaf PTE is
Expand Down
13 changes: 5 additions & 8 deletions src/iommu_sw_guidelines.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -112,13 +112,10 @@ The guidelines for initializing the IOMMU are as follows:
.. If `Dw` is less than or equal to 7-bits and `1LVL` is supported then `M = 1LVL`
.. If `Dw` is less than or equal to 16-bits and `2LVL` is supported then `M = 2LVL`
.. If `Dw` is less than or equal to 24-bits and `3LVL` is supported then `M = 3LVL`

+
Program the `ddtp` register as follows:

** `temp_ddtp_var.iommu_mode = M`
** `temp_ddtp_var.PPN = B`
** `ddtp = temp_ddtp_var`
** Program the `ddtp` register as follows:
.. `temp_ddtp_var.iommu_mode = M`
.. `temp_ddtp_var.PPN = B`
.. `ddtp = temp_ddtp_var`

The IOMMU is initialized and may be now be configured with device-contexts
for devices in scope of the IOMMU.
Expand Down Expand Up @@ -384,7 +381,7 @@ following actions:
.. Process pending fault/event reports that need processing and remove them from
the `FQ` by advancing the `fqh` by the number of records processed.
. If the `ipsr.pip` bit is set then an interrupt is pending from the `PQ`.
.. Read the `pqcsr`register.
.. Read the `pqcsr` register.
.. Determine if an error caused the interrupt and if so, the cause of the error
by examining the state of the `pqmf` and `pqof` bits. If either of these bits
are set then the `PQ` encountered an error and "Page Request" reporting is
Expand Down

0 comments on commit a9b21e7

Please sign in to comment.