Ensure a non-zero return code is set if expected when --no-browser is provided. #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #87. |
|
Will need a version update to merge this. Ref - https://github.com/riscv-software-src/riscof/blob/master/CONTRIBUTING.rst#versioning |
|
Added entry to change log. |
|
@mlawson-tt please rebase this PR to dev branch (shouldn't be a pain for this PR). Change target to dev branch. Also make an entry in CHANGELOG.md under the |
Signed-off-by: Matt Lawson <128844552+mlawson-tt@users.noreply.github.com>
|
@neelgala Should now be rebased on the dev branch, and the entry in the changelog has been moved under the |
neelgala
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change just ensures that the return code is set if non-zero.