retain the original shift instructions as pseudo-ops as well #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is how its done in rv32_i as well.
|
@aswaterman please approve and merge. |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #193 +/- ##
=======================================
Coverage 93.59% 93.59%
=======================================
Files 3 3
Lines 718 718
=======================================
Hits 672 672
Misses 46 46 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@aswaterman reminder to merge this. |
aswaterman
approved these changes
Sep 22, 2023
|
@neelgala Sorry, this got buried in my inbox. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how its done in rv32_i as well. #189 replaced the original pseudo ops instead of just appending new ones. This PR fixes that.