Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move F extension CSRs to the rv_f #276

Merged

Conversation

AFOliveira
Copy link
Contributor

As mentioned in #275, this PR moves "F" extension pseudo-ops that were in the rv_zicsr to rv_f

Signed-off-by: Afonso Oliveira <Afonso.Oliveira@synopsys.com>
@AFOliveira
Copy link
Contributor Author

On a slightly different topic, I also found that several pseudo-instructions from the ASM manual are not described in this repo (like mv, nop, bleu, bgtu), is there any reason for this or shall I go ahead and commit the ones I can find?

@aswaterman
Copy link
Member

I confess I don't know what the discipline for including or excluding pseudo-ops has been. For my purposes, adding MV, NOP, etc. would not add any value, but I can't speak for others.

@aswaterman aswaterman merged commit 41c6b4d into riscv:master Aug 22, 2024
2 checks passed
@AFOliveira
Copy link
Contributor Author

If this repo had all the instructions and pseudo-instructions in the ISA, I think it would allow for a range of tools to use them as a DB.
I don't know if you've checked out this PR I made riscv/riscv-isa-manual/pull/1603, but having all the instructions and pseudo instructions here in riscv-opcodes would make it possible to generate a full list in .adoc and then pdf. Whatever the use case for that might end up on being I think that it illustrates one thing in which this addition could help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants