Add Sail asciidoc documentation target to Makefile #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this not be per-ARCH? Which files are included varies between RV32 and RV64. Even if technically the set of instruction sources is the same. |
Alasdair
force-pushed
the
asciidoc_makefile
branch
from
7fb32ea
to
43e30b9
Compare
Alasdair
force-pushed
the
asciidoc_makefile
branch
from
43e30b9
to
1d274b7
Compare
|
Updated to be per-arch. Possibly not that useful because the code is mostly the same, other than the virtual memory code. I think that code could probably be merged so it's parametric and therefore not per-arch, but not sure when I'd have the time to do that. |
|
Agreed, and you’d need that anyway for mutable S-mode XLEN |
billmcspadden-riscv
approved these changes
Jun 27, 2023
billmcspadden-riscv
added
the
tgmm-agenda
|
Merge approved at the tech-golden-model meeting on 2023-06-27 |
billmcspadden-riscv
removed
the
tgmm-agenda
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an Asciidoctor plugin that allows incorporating Sail code into ISA manuals written using asciidoc. See https://github.com/Alasdair/asciidoctor-sail. This requires generating a json file using Sail that indexes the source code in the repository. This commit simply adds a target for creating that to the Makefile.
Currently requires the development version of Sail, but I am working on making a new opam release of Sail for the documentation support, and there should be no harm in getting the Makefile target here set up in advance, or for those who are already using a development build.