Use separators, not spaces, between operands #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `model/riscv_insts_zfa.sail`, there are quite a few cases where
spaces (`spc()`) are utilized instead of separators (`sep()`) between operands:
```
mapping clause assembly = RISCV_FMAXM_D(rs2, rs1, rd)
<-> "fmaxm.d" ^ spc() ^ freg_name(rd)
^ spc() ^ freg_name(rs1)
^ spc() ^ freg_name(rs2)
```
In the assembly representation, spaces are between the mnemonic and
its operands, and separators are between operands.
Fix the errant cases.
Signed-off-by: Paul A. Clarke <pclarke@ventanamicro.com>
jrtc27
approved these changes
Oct 28, 2023
|
This PR is trivial and has a positive review. Is there any reason it's not been merged after 2 weeks? |
|
I've been travelling (RISCV summit). I'll take a look at it tomorrow(
Friday).
Bill Mc
…On Thu, Nov 9, 2023, 2:18 PM Alexander Richardson ***@***.***> wrote:
This PR is trivial and has a positive review. Is there any reason it's not
been merged after 2 weeks?
—
Reply to this email directly, view it on GitHub
<#332 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXROLOGFEQWHPPA2OKP7NNTYDVJEFAVCNFSM6AAAAAA6TSZZT6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBUG43TCOJWHA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
model/riscv_insts_zfa.sail, there are quite a few cases where spaces (spc()) are utilized instead of separators (sep()) between operands:In the assembly representation, spaces are between the mnemonic and its operands, and separators are between operands.
Fix the errant cases.