Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Zicfilp extension #361

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

ved-rivos
Copy link
Contributor

@jrtc27
Copy link
Collaborator

jrtc27 commented Nov 28, 2023

It should not take 15 commits like that to add this extension. Please condense into a sensible history.

@ptomsich
Copy link
Collaborator

It should not take 15 commits like that to add this extension. Please condense into a sensible history.

The part that Jessica didn't make explicit is: we use a "rebase and merge" strategy and don't squash your history when merging, so your history should be considered part of the submission.

@ved-rivos ved-rivos force-pushed the zicfilp_1127 branch 2 times, most recently from fbb882c to 908f10e Compare November 28, 2023 12:38
@ved-rivos
Copy link
Contributor Author

It should not take 15 commits like that to add this extension. Please condense into a sensible history.

Sorry, that the commit history was nonsense. I have squashed some of the commits. Let me know if it makes sense now.

Copy link

github-actions bot commented Mar 29, 2024

Test Results

712 tests  ±0   712 ✅ ±0   0s ⏱️ ±0s
  6 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 1056a62. ± Comparison against base commit 40ed0c5.

♻️ This comment has been updated with latest results.

- Add machine security configuration register - mseccfg
- Legalize menvcfg and senvcfg separately. Some fields of senvcfg are modulated by menvcfg.
- Make mstatush writeable and add a legalizer function for it.
- mstatus : MPELP, SPELP
- menvcfg : LPE
- senvcfg : LPE
- JALR updates ELP to LP expected on indirect call/jump
- Traps preserve ELP state in mstatus.xPELP on trap delivery priv x
- xRET restores ELP from mstatus.xPELP
- If instruction fetched not LPAD when ELP is LP_EXPECTED cause SW check fault
- Add elp state register and its initialization
- xLPE to track if landing pads enabled at priv x
- Functions that implement ELP state management
- LPAD instruction
@ved-rivos ved-rivos changed the title Add unratified Zicfilp extension Add Zicfilp extension Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants