Fix kext warning #366
Merged
Fix kext warning #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use fixed-length vectors for AES tables Note that because we have `default Order dec`, Sail vectors are indexed the same as bitvectors, in decreasing order, hence why the indexing in sbox_lookup becomes ``` table[255 - unsigned(x)] ``` rather than ``` table[unsigned(x)] ``` The alternative would be to flip all the literals
|
Could you use |
Timmmm
approved these changes
Dec 6, 2023
billmcspadden-riscv
approved these changes
Dec 6, 2023
The Order parameter on vectors no longer does anything (all vectors and bitvectors have the default order). It never worked well and was a big source of internal complexity and headaches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use fixed-length vectors for AES tables. This fixes a warning about an incomplete match, and should be much more efficient than using linked lists. It also makes the Sail->SystemVerilog translation happy as a nice bonus.
Note that because we have
default Order dec, and Sail vectors are indexed the same as bitvectors in decreasing order, the indexing in sbox_lookup becomesrather than
The alternative would be to reverse all the table literals.