-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shorten copyright notice at the top of each file #389
Shorten copyright notice at the top of each file #389
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is a big improvement over copy-pasting the author list to every new file.
f0297e4
to
d17549c
Compare
Rebased and added Google. @billmcspadden-riscv is it ok to merge this? It would make it a lot more pleasant to work on the code! |
You haven’t integrated Alex’s review comments |
d17549c
to
ced4040
Compare
Ooops not sure what happened there. Should be fixed now. I also updated the year to 2024. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is a huge improvement. Would be good to get this merged soon to avoid it being copy-pasted into more new files.
Still not done |
This script was used to do the modification: ``` from pathlib import Path import re RE_LINE = r"/\*={50,150}\*/\n" RE_MIDDLE = r"/\*.*\*/\n" NEW_TEXT = """/*=======================================================================================*/ /* This Sail RISC-V architecture model, comprising all files and */ /* directories except where otherwise noted is subject the BSD */ /* two-clause license in the LICENSE file. */ /* */ /* SPDX-License-Identifier: BSD-2-Clause */ /*=======================================================================================*/ """ REPLACEMENT = re.compile(rf"^{RE_LINE}(?:{RE_MIDDLE}){{10,100}}{RE_LINE}") def main(): for file in Path("model").glob("**/*.sail"): text = file.read_text(encoding="utf-8") text = REPLACEMENT.sub(NEW_TEXT, text, 1) file.write_text(text, encoding="utf-8") if __name__ == "__main__": main() ```
ced4040
to
b5f67e4
Compare
Oops sorry - I promise that wasn't intentional! 😬 I just suck at copy & pasting apparently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The handful of representatives I was checking had been deleted all seem gone now, thanks
I also collated all the authors from the files and from git history and alphabetised them.
Fixes #358
This script was used to do the modification: