Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive xlen values from a logarithmic constant #447

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

Timmmm
Copy link
Collaborator

@Timmmm Timmmm commented Apr 9, 2024

The motivation for this is that it makes deriving CHERI constants (field widths etc.) which vary between RV32 and RV64 a lot easier.

Copy link

github-actions bot commented Apr 9, 2024

Test Results

712 tests  ±0   712 ✅ ±0   0s ⏱️ ±0s
  6 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit d1c3478. ± Comparison against base commit a58c58c.

♻️ This comment has been updated with latest results.

@arichardson
Copy link
Collaborator

Sounds like this needs a new sail version? Would be good if there was a new sail release soon (@Alasdair is this planned soon?) and we can add a version check (#370).

Copy link
Collaborator

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me and CI seems happy.

Makefile Outdated Show resolved Hide resolved
@Timmmm
Copy link
Collaborator Author

Timmmm commented Aug 30, 2024

Yeah I think it's because CI doesn't pin the version of the Sail compiler we use, so when the newer version was released which supports these types it magically fixed this PR even though I didn't change anything.

#532 will pin the Sail compiler version.

@jordancarlin
Copy link
Contributor

jordancarlin commented Aug 30, 2024

Probably worth merging an updated version of #370 before we merge this to prevent issues for anyone still running Sail 0.17. That way they will at least get a descriptive error message. Might also be worth getting #532 finished so that when people update, they can use the new binary installation.

The motivation for this is that it makes deriving CHERI constants (field widths etc.) which vary between RV32 and RV64 a lot easier.
Copy link
Contributor

@jordancarlin jordancarlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to go now that #534 is merged.

@Timmmm Timmmm merged commit 31f8093 into riscv:master Sep 12, 2024
2 checks passed
@Timmmm Timmmm deleted the user/timh/xlen branch September 23, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants