Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MUL instruction #466

Merged
merged 1 commit into from
May 12, 2024
Merged

Commits on May 12, 2024

  1. Refactor MUL instruction

    This instruction had a bit of a case of 'boolean blindness' code smell,
    where the mul operation was represented as a triple of booleans. This
    commit refactors the implemention to use a struct with named fields for
    high, signed_rs1, and signed_rs2.
    
    The C_MUL instruction in Zcb also needs to be changed appropriately
    
    The mul_op struct was added in riscv_types
    
    While there do some housekeeping w.r.t the comment about a workaround for
    Sail < 0.15.1, as this is no longer needed.
    Alasdair committed May 12, 2024
    Configuration menu
    Copy the full SHA
    f852d65 View commit details
    Browse the repository at this point in the history