Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ext_data_get_addr to use bytes for width #468

Merged

Conversation

Timmmm
Copy link
Collaborator

@Timmmm Timmmm commented May 15, 2024

Instead of word_width which can only be up to 8 bytes, just use bytes. This allows larger accesses (the limit is increased to 4096), e.g. for cbo.zero.

This is a pre-requisite for #455 but should be uncontroversial so I think we can merge it first.

It will require a corresponding (easy) change to the CHERI repo.

Copy link

github-actions bot commented May 15, 2024

Test Results

712 tests  ±0   712 ✅ ±0   0s ⏱️ ±0s
  6 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 9194dd5. ± Comparison against base commit e1663e9.

♻️ This comment has been updated with latest results.

Instead of `word_width` which can only be up to 8 bytes, just use bytes. This allows larger accesses (the limit is increased to 4096), e.g. for `cbo.zero`.
@Timmmm Timmmm force-pushed the user/timh/cheri_width_bytes branch from 0070246 to 9194dd5 Compare June 3, 2024 15:02
Copy link
Collaborator

@billmcspadden-riscv billmcspadden-riscv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@billmcspadden-riscv billmcspadden-riscv merged commit b15c0d3 into riscv:master Jun 3, 2024
2 checks passed
@Timmmm Timmmm deleted the user/timh/cheri_width_bytes branch June 12, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants