Change ext_data_get_addr to use bytes for width #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timmmm
force-pushed
the
user/timh/cheri_width_bytes
branch
from
95be70b
to
0070246
Compare
Instead of `word_width` which can only be up to 8 bytes, just use bytes. This allows larger accesses (the limit is increased to 4096), e.g. for `cbo.zero`.
Timmmm
force-pushed
the
user/timh/cheri_width_bytes
branch
from
0070246
to
9194dd5
Compare
arichardson
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
word_widthwhich can only be up to 8 bytes, just use bytes. This allows larger accesses (the limit is increased to 4096), e.g. forcbo.zero.This is a pre-requisite for #455 but should be uncontroversial so I think we can merge it first.
It will require a corresponding (easy) change to the CHERI repo.