csim: Fix C23 compatability warning #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plat_get_16_random_bits was missing its unit argument, which produces the following warning: ``` generated_definitions/c/riscv_model_RV64.c:28041:34: warning: passing arguments to 'plat_get_16_random_bits' without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype] zseed = plat_get_16_random_bits(UNIT); ``` This commit adds the appropriate argument to the function in the C simulator
Timmmm
reviewed
May 21, 2024
Timmmm
approved these changes
May 21, 2024
billmcspadden-riscv
pushed a commit
that referenced
this pull request
May 24, 2024
debug: pylint fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plat_get_16_random_bits was missing its unit argument, which produces the following warning when using clang:
This commit adds the appropriate argument to the function in the C simulator.