Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bitfield syntax #484

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

jordancarlin
Copy link
Contributor

Update remaining uses of old bitfield syntax and replace with the newer syntax (see #373).

The latest version of the sail repo gives the below deprecation warning, which I assume will be included in the next release of sail. This prevents warning messages when that happens.

Warning: Deprecated model/riscv_pmp_regs.sail:71.19-34:
71 |  let match_type = pmpcfg_n[n].A();
   |                   ^-------------^
   | 
Old bitfield syntax, use '<bitfield>[A]' instead

Copy link

github-actions bot commented May 21, 2024

Test Results

712 tests  ±0   712 ✅ ±0   0s ⏱️ ±0s
  6 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 3dcc942. ± Comparison against base commit 5168ced.

♻️ This comment has been updated with latest results.

model/riscv_vmem_pte.sail Outdated Show resolved Hide resolved
Copy link
Collaborator

@Timmmm Timmmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Alasdair Alasdair merged commit af5c2f2 into riscv:master May 21, 2024
2 checks passed
@jordancarlin jordancarlin deleted the bitfieldSyntax branch May 21, 2024 23:19
billmcspadden-riscv pushed a commit that referenced this pull request May 24, 2024
Fix for test program compilation failures due to lack of `zicsr` extension in `-march=rvXX...`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants