Remove redundant CSR privilege checks #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timmmm
force-pushed
the
user/timh/redundant_access_checks
branch
from
50b6448
to
f5b67c6
Compare
arichardson
approved these changes
Jul 9, 2024
These mode levels are already checked by `csrPriv()` so there's no need to do it again. Removing these checks from `is_CSR_defined()` also means that function name is now correct. Since the Privilege parameter is no longer used I removed it. Fixes riscv#402
Timmmm
force-pushed
the
user/timh/redundant_access_checks
branch
from
f5b67c6
to
0d8b50e
Compare
Timmmm
pushed a commit
to Timmmm/sail-riscv
that referenced
this pull request
Oct 2, 2024
debug: Re-enable unavailable tests, and fix them for github
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These mode levels are already checked by
csrPriv()so there's no need to do it again. Removing these checks fromis_CSR_defined()also means that function name is now correct.Fixes #402