Fix innocuous issues with extension tagging #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The `end` statement for `scattered enum extension` misspelled `extension`. - `end extensionEnabled` was inadvertently dropped, and now been restored.
|
These issues snuck into PR #506 . |
Alasdair
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
I fixed the issue that let these slip past in the first place, so we should get this merged otherwise you'll now see:
Type error:
model/riscv_insts_end.sail:30.0-14:
30 |end extensions
|^------------^
| extensions is not a scattered definition, so it cannot be ended
Timmmm
approved these changes
Jul 23, 2024
billmcspadden-riscv
pushed a commit
to billmcspadden-riscv/sail-riscv
that referenced
this pull request
Oct 1, 2024
- The `end` statement for `scattered enum extension` misspelled `extension`. - `end extensionEnabled` was inadvertently dropped, and now been restored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
endstatement forscattered enum extensionmisspelledextension.end extensionEnabledwas inadvertently dropped, and now been restored.