Vector: Remove some unused result variables #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some vector instructions that use `init_masked_result_cmp` but do not use the returned result variable, so just discard it rather than create a new variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some vector instructions that use
init_masked_result_cmpbut do not use the returned result variable, so just discard it rather than create a new variable.I didn't spot these in my previous re-factoring because I was checking that what I was doing was working with Sail 0.18, but since then I've added some warnings that can catch unused variables and they flagged these two cases where part of the return value from
init_masked_result_cmpisn't being used.